The scribe rc script seems to be missing the defination to check if it is enabled in /etc/rc.conf. This causes it to automatically start on boot and if someone runs /usr/local/etc/rc.d/scribe start. This also causes an unexpected operator error when it is run: [root@erik /usr/local/etc/rc.d]# grep scribe /etc/rc.conf [root@erik /usr/local/etc/rc.d]# ./scribe start [: /usr/sbin/daemon: unexpected operator Starting scribe. Fix: The attached patch adds the rcvar variable which seems to fix the problem. How-To-Repeat: 1. Install net/scribe 2. Issue /usr/local/etc/rc.d/scribe start
State Changed From-To: open->feedback I made some improvements to the rc.d script, because the error still appeared after I applied the patch. I also noticed that the port was missing a dependency for devel/py-thrift. That prevented the example scripts from working, although they also need some work in their shebang lines to reference the correct Python installation. Please check my diff here and let me know if it works for you: http://people.freebsd.org/~glarkin/diffs/scribe-2.2.diff
Responsible Changed From-To: freebsd-ports-bugs->glarkin I'll take it.
glarkin 2011-05-13 13:53:55 UTC FreeBSD ports repository Modified files: net/scribe Makefile net/scribe/files scribe.in Log: - Fixed rc.d script so it adheres to rc.conf setting [1] - Added missing dependency on devel/py-thrift - Bumped PORTREVISION PR: ports/154942 (based on) Submitted by: Erik Steigler <erik@okcupid.com> [1] Approved by: maintainer timeout (18 days) Revision Changes Path 1.6 +4 -2 ports/net/scribe/Makefile 1.2 +16 -3 ports/net/scribe/files/scribe.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed with some modifications, thank you!