newsyslog sends SIGHUP to /var/run/munin/munin-node.pid after rotating log files, this causes munin-node to loose $PATH and some plugins stop working as expected. (ntp_kernel_err, ntp_kernel_pll_freq, ntp_kernel_pll_off, postfix_mailqueue, coretemp and dev_cpu_). I didn't checked all plugins, so maybe there are more affected by this problem. Fix: the attached diff adds absolute paths to mentioned plugins as a workaround, maybe there is a better way to fix the $PATH issue? Patch attached with submission follows: How-To-Repeat: kill -HUP `cat /var/run/munin/munin-node.pid` and check /var/log/munin-node.log for errors
Responsible Changed From-To: freebsd-bugs->des Make this a ports PR and assign.
Responsible Changed From-To: des->flo I'll take care of this PR.
flo 2011-03-09 23:40:14 UTC FreeBSD ports repository Modified files: sysutils/munin-node Makefile Added files: sysutils/munin-node/files patch-node__sbin__munin-node patch-node__sbin__munin-node-configure patch-node__sbin__munin-run Log: - fix a bug where plugins would stop graping data after a SIGHUP to munin-node - prevent leftovers from sed and patch otherwise these would be installed also The problem is that munin-nodes runs in perl taint mode and after a SIGHUP p5-Net-Server thinks that the path is tainted and unsets the complete path, this causes all plugins which do not use an absolute path to utilities they call to fail. The fix is to set a well known good path. Obtained from: OpenBSD PR: ports/155109 Revision Changes Path 1.41 +9 -1 ports/sysutils/munin-node/Makefile 1.1 +12 -0 ports/sysutils/munin-node/files/patch-node__sbin__munin-node (new) 1.1 +13 -0 ports/sysutils/munin-node/files/patch-node__sbin__munin-node-configure (new) 1.1 +12 -0 ports/sysutils/munin-node/files/patch-node__sbin__munin-run (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed I added a patch which should fix all plugins