Bug 155536 - devel/quilt: deprecate
Summary: devel/quilt: deprecate
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Edwin Groothuis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-13 17:10 UTC by Rene Ladan
Modified: 2011-03-21 21:00 UTC (History)
0 users

See Also:


Attachments
file.diff (586 bytes, patch)
2011-03-13 17:10 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2011-03-13 17:10:09 UTC
devel/quilt depends on the shells/bash3, the latter expired on 2011-01-21 and is kept alive just for the former port.
See http://www.freshports.org/ports-expired.php

Another possibility would be to upgrade this port to use shells/bash (bash 4).

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-13 17:10:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-13 17:10:23 UTC
Maintainer of devel/quilt,

Please note that PR ports/155536 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155536

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-13 17:10:25 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-16 20:59:15 UTC
Responsible Changed
From-To: rene->edwin

Dirk asked me to handle this.
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-03-16 21:02:49 UTC
edwin       2011-03-16 21:02:36 UTC

  FreeBSD ports repository

  Modified files:
    devel/quilt          Makefile 
  Log:
  Add depricated fields, as okayed by Dirk Jagdman.
  He says he is/will work together with the developer of quilt to
  address the pending issues with regarding to scripts failing under
  bash4.
  
  PR:             ports/155536
  Submitted by:   rene@
  Approved by:    Dirk Jagdman (maintainer) via private email.
  
  Revision  Changes    Path
  1.13      +2 -0      ports/devel/quilt/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 doj 2011-03-20 07:20:30 UTC
I have checked that quilt is working with bash4 without problems and therefore
made the following patch to the quilt port.

Index: quilt/Makefile
===================================================================
--- quilt.orig/Makefile
+++ quilt/Makefile
@@ -7,17 +7,15 @@

 PORTNAME=	quilt
 PORTVERSION=	0.48
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_SAVANNAH}
 MASTER_SITE_SUBDIR=	quilt

 MAINTAINER=	doj@cubic.org
-COMMENT=	A collection of bash3 scripts to ease working with patch files
-DEPRECATED=	Depends on expired shells/bash3
-EXPIRATION_DATE=2011-05-01
+COMMENT=	A collection of bash scripts to ease working with patch files

-BUILD_DEPENDS=	bash:${PORTSDIR}/shells/bash3 \
+BUILD_DEPENDS=	bash:${PORTSDIR}/shells/bash \
 		gcp:${PORTSDIR}/sysutils/coreutils \
 		gsed:${PORTSDIR}/textproc/gsed \
 		gpatch:${PORTSDIR}/devel/patch \
@@ -26,6 +24,8 @@ BUILD_DEPENDS=	bash:${PORTSDIR}/shells/b
 		formail:${PORTSDIR}/mail/procmail
 RUN_DEPENDS+=	${BUILD_DEPENDS}

+LICENSE=	GPLv2
+
 USE_GMAKE=	yes
 USE_PERL5=	yes

Index: quilt/distinfo
===================================================================
--- quilt.orig/distinfo
+++ quilt/distinfo
@@ -1,3 +1,2 @@
-MD5 (quilt-0.48.tar.gz) = f77adda60039ffa753f3c584a286f12b
 SHA256 (quilt-0.48.tar.gz) =
73fd760d3b5cbf06417576591dc37d67380d189392db9000c21b7cbebee49ffc
 SIZE (quilt-0.48.tar.gz) = 421146
Index: quilt/pkg-descr
===================================================================
--- quilt.orig/pkg-descr
+++ quilt/pkg-descr
@@ -5,7 +5,6 @@ The key philosophical concept is that yo
 patches. Not ".c" files, not ".h" files. But patches. So patches are
 the first-class object here.
 Quilt was originally based on Andrew Morton's patch scripts published
-on the linux kernel mailing list a while ago, but where heavily
-modified since then.
+on the linux kernel mailing list.

 WWW: http://savannah.nongnu.org/projects/quilt




--------------------------------------------------------------------------------

> Maintainer of devel/quilt,
> 
> Please note that PR ports/155536 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155536
>
Comment 7 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-21 20:54:34 UTC
State Changed
From-To: feedback->closed

Commited, thanks!
Comment 8 dfilter service freebsd_committer freebsd_triage 2011-03-21 20:59:21 UTC
edwin       2011-03-21 20:59:13 UTC

  FreeBSD ports repository

  Modified files:
    devel/quilt          Makefile distinfo pkg-descr 
  Log:
  devel/quilt - un-deprecate and make it depend on bash4
  
  PR:             ports/155536
  Submitted by:   doj@cubic.org
  
  Revision  Changes    Path
  1.14      +4 -4      ports/devel/quilt/Makefile
  1.4       +0 -1      ports/devel/quilt/distinfo
  1.2       +1 -2      ports/devel/quilt/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"