Bug 155779 - [PATCH] mail/policyd2: fix RC script
Summary: [PATCH] mail/policyd2: fix RC script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sahil Tandon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 12:30 UTC by Frank Wall
Modified: 2011-05-11 02:20 UTC (History)
0 users

See Also:


Attachments
file.diff (319 bytes, patch)
2011-03-22 12:30 UTC, Frank Wall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Wall 2011-03-22 12:30:01 UTC
The RC script for mail/policyd2 is broken, because it interferes with other perl daemons. The problem is that procname="/usr/bin/perl" is specified. This will match most other perl daemons as well. 

So instead of stopping/restarting mail/policyd2, ALL your other perl daemons are going to be killed. Not exactly what I want if I try to stop mail/policyd2. IMHO this is a serious issue.

The attached patch fixes this problem by replacing "procname" with "command_interpreter".

Fix: apply the patch

Patch attached with submission follows:
How-To-Repeat: 1. choose any perl daemon, for example net-mgmt/snmptt, and install it

2. start this perl daemon:
# /usr/local/etc/rc.d/snmptt onestart
Starting snmptt.
# /usr/local/etc/rc.d/snmptt onestatus
snmptt is running as pid 54922.

3. now check policyd2 daemon status
# /usr/local/etc/rc.d/policyd2 onestatus
policyd2 is running as pid 54921 54922.

4. You will recognize that the PID 54922 for policyd2 actually is the PID for your other pearl daemon, snmptt. This is wrong.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-22 12:30:13 UTC
Maintainer of mail/policyd2,

Please note that PR ports/155779 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155779

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-22 12:30:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 chifeng 2011-03-23 10:40:06 UTC
Sure, please commit it, thank you.

Chifeng

-- 
*Regards.*
**- Chifeng
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2011-03-23 11:42:07 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Sahil Tandon freebsd_committer freebsd_triage 2011-05-09 04:07:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sahil

Take.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-05-11 02:19:04 UTC
sahil       2011-05-11 01:18:51 UTC

  FreeBSD ports repository

  Modified files:
    mail/policyd2        Makefile 
    mail/policyd2/files  policyd2.sh.in 
  Log:
  Use command_interpreter instead of procname in
  rc script. Bump PORTREVISION because this change
  alters the default package.
  
  PR:             ports/155779
  Submitted by:   Frank Wall <fw@moov.de>
  Approved by:    Chifeng QU <chifeng@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.11      +1 -0      ports/mail/policyd2/Makefile
  1.3       +2 -2      ports/mail/policyd2/files/policyd2.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Sahil Tandon freebsd_committer freebsd_triage 2011-05-11 02:19:15 UTC
State Changed
From-To: open->closed

Committed. Thanks!