155934 – Incorporate patch from the Ice project into devel/mcpp

no flags

The Ice project by ZeroC (devel/ice and devel/py-ice) did some patches and security updates for the mcpp preprocessor. Without those patches, important parts of ice are not functioning properly. The patches have been applied to various linux package trees in the past successfully. I got in touch with the author and package maintainer of the devel/mcpp port, but he's currently unable to do any work on the project, but gave his consent to applying the patch:

====
Hello,

I'm very sorry, but I have no time for mcpp now.  I think the Zeroc
patch is correct, and has no undesirable side effect.  So, if someone
make an mcpp package applying the patch, and commit it to FreeBSD or any
other system, I will agree with it.

--
Kiyoshi Matsui, the maintainer of mcpp
===

It should be emphasized, that right now ice is the only port using mcpp and that it's misbehaving in subtle ways if the patch is not applied at runtime. So this is somehow critical.

Fix: Apply the patch attached to this PR and reinstall mcpp:

sudo mkdir -p /usr/ports/devel/mcpp/files
sudo cp patch-mcpp-ice.txt /usr/ports/devel/mcpp/files
sudo portupgrade -f devel/mcpp

It would be good, if this patch could be incorporated into the port skeleton of devel/mcpp directly. The original patch is part of the third party sources tarball found on zeroc.com: http://www.zeroc.com/download/Ice/3.4/ThirdParty-Sources-3.4.1.tar.gz

Patch attached with submission follows:
How-To-Repeat: Run mcpp like this:
mcpp -C << EOF
> test; // comment
> EOF
#line 1 "<stdin>"
// commenttest;

This clearly shows the critical misbehaviour when comments are preserved (that's the way slice2java, slice2py and slice2html are calling mcpp).