Bug 156453 - [PATCH] Unbreak port: emulators/pearpc Add missing nasm dependency
Summary: [PATCH] Unbreak port: emulators/pearpc Add missing nasm dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-17 09:40 UTC by Chris Rees
Modified: 2011-04-26 01:50 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees 2011-04-17 09:40:09 UTC
	PearPC has been marked broken [1] for a while, but closer investigation revealed the problem to be missing nasm dependency.

	[1] http://www.mail-archive.com/freebsd-ports@freebsd.org/msg33333.html

Fix: - Add missing dependency on nasm -- unbreak
	- While here, add LICENSE and remove MD5 checksum

	Submitted by: utisoft@gmail.com



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.--ThTiQyBQKdqpIEQDQnBJ5BEBb7OAMsGZYxEWZkj6LEiqjXn0
Content-Type: text/plain; name="pearpc-nasm-depend.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="pearpc-nasm-depend.diff"

Index: Makefile
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/emulators/pearpc/Makefile,v
retrieving revision 1.34
diff -u -r1.34 Makefile
--- Makefile	17 Mar 2011 11:08:39 -0000	1.34
+++ Makefile	17 Apr 2011 08:29:56 -0000
@@ -14,9 +14,9 @@
 MAINTAINER=	novel@FreeBSD.org
 COMMENT=	PowerPC architecture emulator
 
-BROKEN=		does not build
-DEPRECATED=	has been broken for over a half year
-EXPIRATION_DATE=2011-04-17
+BUILD_DEPENDS=	nasm:${PORTSDIR}/devel/nasm
+
+LICENSE=	GPL
 
 GNU_CONFIGURE=	yes
 USE_XORG=	x11
Index: distinfo
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/emulators/pearpc/distinfo,v
retrieving revision 1.5
diff -u -r1.5 distinfo
--- distinfo	22 Dec 2005 12:07:37 -0000	1.5
+++ distinfo	17 Apr 2011 08:29:56 -0000
@@ -1,3 +1,2 @@
-MD5 (pearpc-0.4.tar.gz) = c0eaeb588da2d6cd0ccfd62ea426e35f
 SHA256 (pearpc-0.4.tar.gz) = cf9501dc95b418dc9632e57c75d59e78ec5204db0ed6b41abced2cea30021cce
 SIZE (pearpc-0.4.tar.gz) = 910621
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-17 09:40:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->novel

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2011-04-20 23:19:27 UTC
Hi,

This patch probably is not quite correct as you can see there's a
dependency on nasm already, it's conditional though. Obviously, there's
something wrong with conditions for it, but we need to understand what
exactly.

Roman Bogorodskiy
Comment 3 Chris Rees 2011-04-21 09:57:43 UTC
Oops, you're right, sorry.

Modified patch [1] takes out the JITC option; there's an i386-specific
section in src/system/arch that needs nasm anyway... if we're going
through the installation of nasm on i386 then we may as well make use
of the optimisations.

Alternatively, you could leave the OPTION in and code around that?

Chris

[1] http://www.bayofrum.net/~crees/patches/pearpc-nasm-depend.diff
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-04-26 01:45:22 UTC
novel       2011-04-26 00:45:04 UTC

  FreeBSD ports repository

  Modified files:
    emulators/pearpc     Makefile distinfo 
  Added files:
    emulators/pearpc/files patch-src-system-osapi-posix-types.h 
  Log:
  - Unbreak by fixing nasm dependency
  - Define LICENCE
  - Nuke MD5
  
  PR:             156453 (based on)
  Submitted by:   Chris Rees <utisoft@gmail.com>
  
  Revision  Changes    Path
  1.35      +3 -6      ports/emulators/pearpc/Makefile
  1.6       +0 -1      ports/emulators/pearpc/distinfo
  1.1       +18 -0     ports/emulators/pearpc/files/patch-src-system-osapi-posix-types.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Roman Bogorodskiy freebsd_committer freebsd_triage 2011-04-26 01:48:50 UTC
State Changed
From-To: open->closed

Committed, thanks!