Some clients that are sending NONE as property in their ConvertSelection request: ............REQUEST: ConvertSelection sequence number: 012c request length: 0006 requestor: WIN 0260000d selection: <PRIMARY> target: <STRING> property: <NONE> time: CurrentTime ..............EVENT: SelectionRequest sequence number: 0208 time: CurrentTime owner: WIN 02400008 requestor: WIN 0260000d selection: <PRIMARY> target: <STRING> property: <NONE> ..............ERROR: Atom Receipt of SelectionRequest with <NONE> property causes rxvt derivatives to crash with BadAtom error. ICCCM says, that only obsolete clients should behave like this, and t recommends that clients owning selection should use the target atom as the property name. (see http://tronche.com/gui/x/icccm/sec-2.html#s-2.2) xterm is handling this, but rxvt and derivatives do not. Submitted upstream: (rxvt) https://sourceforge.net/tracker/?func=detail&aid=3289852&group_id=221&atid=100221 (rxvt-unicode) http://thread.gmane.org/gmane.comp.terminal-emulators.rxvt-unicode.general/958 Added file(s): - files/patch-screen.c Port maintainer (akosela@andykosela.com) is cc'd. Generated with FreeBSD Port Tools 0.99 How-To-Repeat: Paste from rxvt into comms/syncterm or one of the clients described in: http://michael.toren.net/mirrors/doc/X-copy+paste.txt
Maintainer of x11/rxvt, Please note that PR ports/156542 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156542 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Yes, I'm aware of it. Please commit this patch. --Andy
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->dhn I'll take it.
dhn 2011-06-20 14:50:18 UTC FreeBSD ports repository Modified files: x11/rxvt Makefile Added files: x11/rxvt/files patch-screen.c Log: - Fix crash to paste from non-ICCCM clients - Bump PORTREVISION PR: ports/156542 Submitted by: Marcin Cieslak <saper@saper.info> Approved by: maintainer Revision Changes Path 1.71 +1 -1 ports/x11/rxvt/Makefile 1.1 +52 -0 ports/x11/rxvt/files/patch-screen.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!