Update audio/abraca to 0.6.0. Removed all files in the files directory, and removed the files directory itself.
Maintainer of audio/abraca, Please note that PR ports/156685 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156685 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->beech I'll take it
2011/4/27 Edwin Groothuis <edwin@freebsd.org>: > Maintainer of audio/abraca, > > Please note that PR ports/156685 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. Tested and approved. As I'm not doing a great maintainer job since I'm not using abraca anymore, are you willing to become the new maintainer of this port ? I can continue testing and approving patchs, but I think you'll make a better job. Some things that are not working for me : - the upper right icon is not found (gtk default "blank file" with a red cross) and disabled. I think it should display a slider to adjust mixer volume. The root of the problem seems to come from xmms2, while it plays music files just fine : xmms2> server volume Server error: couldn't get volume xmms2> server volume 10 Failed in file ../src/lib/xmmstypes/value.c on row 1853 I'm using oss with snd_hda.ko, no sound server, no hal. - I can make abraca crash reliably when I start it after having removed its config file, and I do : Music / Add / Files (or Directory) / Cancel (or ESC) one or two times. It then can't restart it because the config file is empty : ** CRITICAL **: configurable.vala:109: The configuration file '/home/zozo/.config/xmms2/clients/abraca.conf' is corrupted. aborting... Abandon(core dumped) Surely an upstream problem. Thanks for the PR. --=20 Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ASCII ribbon campaign ( ) e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ =A0 "Il y a seulement 10 sortes de gens dans le monde : =A0 ceux qui comprennent le binaire, =A0 et ceux qui ne le comprennent pas."
On 05/03/11 19:25, Olivier Smedts wrote: > 2011/4/27 Edwin Groothuis<edwin@freebsd.org>: >> Maintainer of audio/abraca, >> >> Please note that PR ports/156685 has just been submitted. >> >> If it contains a patch for an upgrade, an enhancement or a bug fix >> you agree on, reply to this email stating that you approve the patch >> and a committer will take care of it. > > Tested and approved. > Thanks! :) > As I'm not doing a great maintainer job since I'm not using abraca > anymore, are you willing to become the new maintainer of this port ? I > can continue testing and approving patchs, but I think you'll make a > better job. > Since I use it I could. Hoping to do a good job :) > Some things that are not working for me : > > - the upper right icon is not found (gtk default "blank file" with a > red cross) and disabled. I think it should display a slider to adjust > mixer volume. The root of the problem seems to come from xmms2, while > it plays music files just fine : > xmms2> server volume > Server error: couldn't get volume > xmms2> server volume 10 > Failed in file ../src/lib/xmmstypes/value.c on row 1853 > I'm using oss with snd_hda.ko, no sound server, no hal. It looks to me like xmms2d does not like to process requests for volume when it is not playing. When playing everything seems to work. The missing icon seems to be cause by something else, but i could be wrong. I'll try to investigate. I noticed some other apps too having this kind of problem. remmina shows a similar missing icon on my PC at work. > > - I can make abraca crash reliably when I start it after having > removed its config file, and I do : > Music / Add / Files (or Directory) / Cancel (or ESC) one or two times. > It then can't restart it because the config file is empty : > ** CRITICAL **: configurable.vala:109: The configuration file > '/home/zozo/.config/xmms2/clients/abraca.conf' is corrupted. > aborting... > Abandon(core dumped) > Surely an upstream problem. > I'll try to check this one too. I think this requires some coding inside abraca to solve. > Thanks for the PR. > Thanks to you for the port :) -- Guido Falsi <mad@madpilot.net>
State Changed From-To: feedback->open Maintainer response, waiting on additional testing
State Changed From-To: open->feedback Waiting for additional information and possible patch
On Tue, May 03, 2011 at 08:11:28PM +0200, Guido Falsi wrote: > > > >- the upper right icon is not found (gtk default "blank file" with a > >red cross) and disabled. I think it should display a slider to adjust > >mixer volume. The root of the problem seems to come from xmms2, while > >it plays music files just fine : > >xmms2> server volume > >Server error: couldn't get volume > >xmms2> server volume 10 > >Failed in file ../src/lib/xmmstypes/value.c on row 1853 > >I'm using oss with snd_hda.ko, no sound server, no hal. > > It looks to me like xmms2d does not like to process requests for > volume when it is not playing. When playing everything seems to > work. > > The missing icon seems to be cause by something else, but i could be > wrong. I'll try to investigate. I finally figured out what is the situation. Abraca uses icons which are included in icon themes(tango and gnome-icon-theme both have the needed icons for example) but not in gtk itself. The default system icon theme (hicolor) is an empty icon theme. People using a desktop environment usually have a real icon theme with all default icons present defined, people like me who stick to a plain old window manager(I'm old fashioned, I know :D ) don't have a default icon theme defined and the system reverts to the empty hicolor one. This can be easily fixed by first install an icon theme(for example Tango from the ports) creating a .gtkrc-2.0 file with the following line: gtk-icon-theme-name = "Tango" and then gtk is able to find the icon required by abraca for the volume slider/button. Now, the problem is, how does the project usually deal with this kind of situation? Should the port print some message stating this situation or can we think that people using no desktop environment will be able to figure this out by themselves? > I noticed some other apps too having this kind of problem. remmina > shows a similar missing icon on my PC at work. Just to solve my doubt, I've now discovered that remmina is healed by the same cure. > > > > >- I can make abraca crash reliably when I start it after having > >removed its config file, and I do : > >Music / Add / Files (or Directory) / Cancel (or ESC) one or two times. > >It then can't restart it because the config file is empty : > >** CRITICAL **: configurable.vala:109: The configuration file > >'/home/zozo/.config/xmms2/clients/abraca.conf' is corrupted. > >aborting... > >Abandon(core dumped) > >Surely an upstream problem. > > > > I'll try to check this one too. I think this requires some coding > inside abraca to solve. I found a cause and a solution. I'm attaching a revised patch which includes a new file: files/patch-src-medialib.vala and, as the old one, removes the following files: files/patch-src-components-collections-collections_view.vala files/patch-src-components-playlist-playlist_model.vala the patch modifies what looks like code which was copied pasted and modified and a call which should have been deleted was not. This causes the program to work on an array of uniinitialized memory, creating a corrupted config file. I'm also trying to file a bug report with the abraca guys about this issue. Greetings! -- Guido Falsi <mad@madpilot.net>
2011/5/11 Guido Falsi <mad@madpilot.net>: > On Tue, May 03, 2011 at 08:11:28PM +0200, Guido Falsi wrote: >> It looks to me like xmms2d does not like to process requests for >> volume when it is not playing. When playing everything seems to >> work. Well not for me, but that's more an xmms2 problem, so there's no need to blame abraca ! >> >- I can make abraca crash reliably when I start it after having >> >removed its config file, and I do : >> >Music / Add / Files (or Directory) / Cancel (or ESC) one or two times. >> >It then can't restart it because the config file is empty : >> >** CRITICAL **: configurable.vala:109: The configuration file >> >'/home/zozo/.config/xmms2/clients/abraca.conf' is corrupted. >> >aborting... >> >Abandon(core dumped) >> >Surely an upstream problem. >> > >> >> I'll try to check this one too. I think this requires some coding >> inside abraca to solve. > > I found a cause and a solution. I'm attaching a revised patch which > includes a new file: > > files/patch-src-medialib.vala > > and, as the old one, removes the following files: > > files/patch-src-components-collections-collections_view.vala > files/patch-src-components-playlist-playlist_model.vala > > the patch modifies what looks like code which was copied pasted and > modified and a call which should have been deleted was not. This > causes the program to work on an array of uniinitialized memory, > creating a corrupted config file. > > I'm also trying to file a bug report with the abraca guys about this > issue. Great job ! But change the "MAINTAINER" line if you want to apply. If you don't, please reply and in this case I agree to commit the patch as is. Thanks :) --=20 Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ASCII ribbon campaign ( ) e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ =A0 "Il y a seulement 10 sortes de gens dans le monde : =A0 ceux qui comprennent le binaire, =A0 et ceux qui ne le comprennent pas."
On Thu, May 12, 2011 at 08:02:23PM +0200, Olivier Smedts wrote: > > Great job ! But change the "MAINTAINER" line if you want to apply. If > you don't, please reply and in this case I agree to commit the patch > as is. Ok, I did not think about the MAINTAINER line. Attaching last revised patch. Thank you again! -- Guido Falsi <mad@madpilot.net>
2011/5/13 Guido Falsi <mad@madpilot.net>: > On Thu, May 12, 2011 at 08:02:23PM +0200, Olivier Smedts wrote: >> >> Great job ! But change the "MAINTAINER" line if you want to apply. If >> you don't, please reply and in this case I agree to commit the patch >> as is. > > Ok, I did not think about the MAINTAINER line. Attaching last revised > patch. Please commit ! > > Thank you again! > > -- > Guido Falsi <mad@madpilot.net> --=20 Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ASCII ribbon campaign ( ) e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ =A0 "Il y a seulement 10 sortes de gens dans le monde : =A0 ceux qui comprennent le binaire, =A0 et ceux qui ne le comprennent pas."
State Changed From-To: feedback->open Received response
beech 2011-05-13 16:39:32 UTC FreeBSD ports repository Modified files: audio/abraca Makefile distinfo audio/abraca/files patch-src-components-collections-collections_view.vala patch-src-components-playlist-playlist_model.vala Added files: audio/abraca/files patch-src-medialib.vala Log: -Update to 0.6.0 -Pass maintainership to submitter PR: ports/156685 Submitted by: Guido Falsi <mad@madpilot.net> Approved by: Olivier Smedts <olivier@gid0.org> (maintainer) itetcu (mentor)(implicit) Revision Changes Path 1.11 +3 -4 ports/audio/abraca/Makefile 1.4 +2 -2 ports/audio/abraca/distinfo 1.2 +0 -23 ports/audio/abraca/files/patch-src-components-collections-collections_view.vala 1.2 +0 -14 ports/audio/abraca/files/patch-src-components-playlist-playlist_model.vala 1.1 +19 -0 ports/audio/abraca/files/patch-src-medialib.vala (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, Thanks!