Bug 156802 - x11-wm/windowmaker: clang: dock.c:3804:9: error: non-void function 'handleIconMove' should return a value [-Wreturn-type]
Summary: x11-wm/windowmaker: clang: dock.c:3804:9: error: non-void function 'handleIco...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Doug Barton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 23:00 UTC by O. Hartmann
Modified: 2011-06-26 06:10 UTC (History)
0 users

See Also:


Attachments
patch-src_dock.c (359 bytes, text/plain)
2011-05-04 08:50 UTC, O. Hartmann
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2011-05-03 23:00:21 UTC
Making all in src
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c actions.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c appicon.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c application.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c appmenu.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c balloon.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c client.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c colormap.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c cycling.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c defaults.c
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c dialog.c
defaults.c:2590:14: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
    if (mask < 0) {
        ~~~~ ^ ~
clang -DHAVE_CONFIG_H -I. -I. -I. -I../wrlib    -I../WINGs -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -DLOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -c dock.c
dock.c:1626:5: warning: implicit declaration of function 'addDockShortcut' is invalid in C99 [-Wimplicit-function-declaration]
        if(addDockShortcut(WMGetFromPLString(cmd), aicon))
           ^
dock.c:1971:9: warning: implicit declaration of function 'rebindKeygrabs' is invalid in C99 [-Wimplicit-function-declaration]
        rebindKeygrabs(dock->screen_ptr);
        ^
dock.c:3804:9: error: non-void function 'handleIconMove' should return a value [-Wreturn-type]
        return;
        ^
dock.c:4520:9: warning: implicit declaration of function 'wXModifierFromKey' is invalid in C99 [-Wimplicit-function-declaration]
                mod = wXModifierFromKey(b);
                      ^
dock.c:4582:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
                        if(done = wDockPerformShortcut(scr->workspaces[i]->clip, event)) break;
                           ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dock.c:4582:12: note: place parentheses around the assignment to silence this warning
                        if(done = wDockPerformShortcut(scr->workspaces[i]->clip, event)) break;
                                ^
                           (                                                           )
dock.c:4582:12: note: use '==' to turn this assignment into an equality comparison
                        if(done = wDockPerformShortcut(scr->workspaces[i]->clip, event)) break;
                                ^
                                ==
4 warnings and 1 error generated.
1 warning generated.
*** Error code 1
1 error
*** Error code 1
1 error
*** Error code 1

Stop in /usr/ports/x11-wm/windowmaker.
*** Error code 1

Stop in /usr/ports/x11-wm/windowmaker.

===>>> make failed for x11-wm/windowmaker
===>>> Aborting update

Terminated

How-To-Repeat: Try to compile x11-wm/windowmaker from most recent ports repository with recent FreeBSD 9.0-CURRENT's "llvm/clang"
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-03 23:00:37 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dougb

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Doug Barton freebsd_committer freebsd_triage 2011-05-04 08:18:36 UTC
State Changed
From-To: open->closed


clang is not officially supported as a ports compiler. OTOH if you would like 
to submit a patch which allows wm to build with clang I'll be happy to test it.
Comment 3 O. Hartmann 2011-05-04 08:50:43 UTC
Patch attached. Simple change.
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-06-26 06:08:47 UTC
dougb       2011-06-26 05:08:34 UTC

  FreeBSD ports repository

  Added files:
    x11-wm/windowmaker/files patch-src_dock.c 
  Log:
  Fix build with clang
  
  PR:             ports/156802
  Submitted by:   "Hartmann, O." <ohartman@zedat.fu-berlin.de>
  
  Revision  Changes    Path
  1.1       +11 -0     ports/x11-wm/windowmaker/files/patch-src_dock.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"