Bug 156994 - net-im/skype-devel: Fix broken port
Summary: net-im/skype-devel: Fix broken port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 05:50 UTC by lichray
Modified: 2011-05-17 09:00 UTC (History)
0 users

See Also:

Attachments
skype-devel_1.patch (1.77 KB, patch)
2011-05-13 05:50 UTC, lichray 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lichray 2011-05-13 05:50:09 UTC 
	
	1. skype, skype12 skype20 all use `skype` as their program names, but this port is different (skype_devel); If it's just different, it's fine, but the Makefile uses a name skype-devel, which is different from that in pkg-plist!
	2. Same, don't change the name of the desktop file. And, the file skype-devel.desktop does not exist.

Fix: Add missing pkg-plist entities, fix naming.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-13 05:50:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 lichray 2011-05-13 06:05:08 UTC 
Btw, we need to make changes to pkg-message at the same time.

Check item 7 "
7. Next version ...
"

which is for net-im/skype, not for this port.

-- 
Zhihao Yuan, nickname lichray
The best way to predict the future is to invent it.
--------------------------------------------------
4BSD - http://lichray.tumblr.com/
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-05-13 07:55:25 UTC 
itetcu      2011-05-13 06:55:11 UTC

  FreeBSD ports repository

  Modified files:
    net-im/skype-devel   Makefile pkg-message 
  Log:
  - fix installation
  - adjust pkg-message, as this is the "next" version :)
  
  PR:             156994
  Submitted by:   Zhihao Yuan <lichray@gmail.com>
  
  Revision  Changes    Path
  1.49      +1 -1      ports/net-im/skype-devel/Makefile
  1.2       +1 -7      ports/net-im/skype-devel/pkg-message
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2011-05-13 07:58:26 UTC 
State Changed
From-To: open->closed

Skype ports updated, thanks for your submissions.
Comment 5 lichray 2011-05-13 08:23:49 UTC 
This port is still broken... you fixed the desktop file, but not the
binary (the one used in pkg-plist is different from the one in
Makefile).

Just apply my patch to the original version, then replace pkg-message.

-- 
Zhihao Yuan, nickname lichray
The best way to predict the future is to invent it.
--------------------------------------------------
4BSD - http://lichray.tumblr.com/
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-05-17 08:56:29 UTC 
itetcu      2011-05-17 07:56:19 UTC

  FreeBSD ports repository

  Modified files:
    net-im/skype-devel   Makefile pkg-plist 
  Log:
  Now that the skype ports are conflicting, don't install anything skype-devel.
  This brings -devel closer to the main port, and of course, fixes install/plist.
  
  PR:             156994
  Submitted by:    Zhihao Yuan <lichray@gmail.com>
  
  Revision  Changes    Path
  1.50      +2 -2      ports/net-im/skype-devel/Makefile
  1.20      +3 -2      ports/net-im/skype-devel/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"