Bug 157098 - [PATCH] multimedia/mplayer: Add USE_NCURSES=yes
Summary: [PATCH] multimedia/mplayer: Add USE_NCURSES=yes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 01:40 UTC by Raphael Kubo da Costa
Modified: 2011-06-26 06:10 UTC (History)
1 user (show)

See Also:


Attachments
mplayer-1.0.r20110329_1.patch (860 bytes, patch)
2011-05-17 01:40 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa 2011-05-17 01:40:08 UTC
mplayer looks for ncurses during its configuration. When devel/ncurses
is installed and one has chosen to use it for ports instead of the one
in base, an implicit dependency is created. When devel/ncurses is
updated, one does not automatically notice mplayer needs to be
recompiled to follow the library bump, which causes problems. Adding
USE_NCURSES=yes should fix this.

I've raised PORTREVISION, but I'm not sure this is necessary.

Port maintainer (riggs@rrr.de) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-17 01:40:16 UTC
Maintainer of multimedia/mplayer,

Please note that PR ports/157098 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157098

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-17 01:40:21 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Thomas E. Zander 2011-05-22 12:45:16 UTC
Patch for Makefile.shared looks good.
I would not bump PORTREVISION, though. This problem tends to hit
*very* few people.
So, I would commit the change to Makefile.shared but not to Makefile itself.

Thank you for your patch! Always appreciated!
Riggs
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2011-05-24 04:04:22 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2011-06-26 06:07:18 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-06-26 06:07:23 UTC
miwi        2011-06-26 05:07:09 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile Makefile.shared 
  Log:
  - set USE_NCURSES
  
  PR:             157098
  Submitted by:   Raphael Kubo da Costa <kubito@gmail.com>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.206     +1 -1      ports/multimedia/mplayer/Makefile
  1.12      +1 -0      ports/multimedia/mplayer/Makefile.shared
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"