Bug 157187 - security/p5-Crypt-OpenSSL-RSA broken under perl 5.14
Summary: security/p5-Crypt-OpenSSL-RSA broken under perl 5.14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-19 21:30 UTC by Mark.Martinec
Modified: 2011-05-26 10:00 UTC (History)
0 users

See Also:


Attachments
file.diff (368 bytes, patch)
2011-05-19 21:30 UTC, Mark.Martinec
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark.Martinec 2011-05-19 21:30:12 UTC
The Perl module Crypt::OpenSSL::RSA (ports: security/p5-Crypt-OpenSSL-RSA)
relies on the undocumented behaviour that DynaLoader ISA AutoLoader
(contrary to the AutoLoader documentation).
This no longer works with Perl 5.14.0, which is now in ports.

Module's selfs tests fail, and so do other modules depending on it,
such as mail/p5-Mail-DKIM (and consequently mail/p5-Mail-SpamAssassin
and security/amavisd-new).

The bug is still unfixed upstream, the patch is simple.

The problem is documented in [perl #84444]:
  http://rt.perl.org/rt3//Public/Bug/Display.html?id=84444

Fix: --- RSA.pm~     2009-11-22 21:36:07.000000000 +0100
+++ RSA.pm      2011-05-19 21:53:08.000000000 +0200
@@ -7,5 +7,5 @@
 
 require DynaLoader;
-require AutoLoader;
+use AutoLoader 'AUTOLOAD';
 
 @ISA = qw(DynaLoader);


Patch attached with submission follows:
How-To-Repeat: (having the perl 5.14 installed from ports)

# cd /usr/ports/security/p5-Crypt-OpenSSL-RSA
# make
# cd work/Crypt-OpenSSL-RSA-0.26/
# make test

 
PERL_DL_NONLAZY=1 /usr/local/bin/perl5.14.0 "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/bignum.t .. Can't locate object method "new_key_from_parameters" via package "Crypt::OpenSSL::RSA" at t/bignum.t line 53.
t/bignum.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 64/64 subtests 
t/format.t .. 1/10 Can't locate object method "new_public_key" via package "Crypt::OpenSSL::RSA" at t/format.t line 33.
t/format.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 6/10 subtests 
t/rsa.t ..... Can't locate object method "import_random_seed" via package "Crypt::OpenSSL::RSA" at t/rsa.t line 62.
t/rsa.t ..... Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 63/63 subtests 

Test Summary Report
-------------------
t/bignum.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 64 tests but ran 0.
t/format.t (Wstat: 65280 Tests: 4 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10 tests but ran 4.
t/rsa.t   (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 63 tests but ran 0.
Files=3, Tests=4,  0 wallclock secs ( 0.04 usr  0.00 sys +  0.04 cusr  0.03 csys =  0.11 CPU)
Result: FAIL
Failed 3/3 test programs. 0/4 subtests failed.
*** Error code 255

Stop in /usr/ports/security/p5-Crypt-OpenSSL-RSA.old/work/Crypt-OpenSSL-RSA-0.26.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-19 21:30:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-05-26 09:58:09 UTC
Responsible Changed
From-To: perl->sunpoet

I will take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-05-26 09:58:29 UTC
sunpoet     2011-05-26 08:58:21 UTC

  FreeBSD ports repository

  Modified files:
    security/p5-Crypt-OpenSSL-RSA Makefile 
  Log:
  - Fix self test with Perl 5.14 [1]
  - Add regression-test:
  - Make portlint happier
  - Bump PORTREVISION for RSA.pm change
  
  PR:             ports/157187 [1]
  Submitted by:   Mark Martinec <Mark.Martinec@ijs.si>
  
  Revision  Changes    Path
  1.25      +12 -4     ports/security/p5-Crypt-OpenSSL-RSA/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-05-26 09:58:53 UTC
State Changed
From-To: open->closed

Committed. Thanks!