Bug 157217 - [PATCH] unbreak graphics/graphviz on -RELEASE (missing log2())
Summary: [PATCH] unbreak graphics/graphviz on -RELEASE (missing log2())
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 18:40 UTC by Christoph Moench-Tegeder
Modified: 2011-06-14 18:30 UTC (History)
0 users

See Also:


Attachments
file.diff (796 bytes, patch)
2011-05-20 18:40 UTC, Christoph Moench-Tegeder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2011-05-20 18:40:11 UTC
	The build of graphics/graphviz on -RELEASE fails because log2() is
	not defined on those versions. The same problem (log2f() in that case)
	happened with graphics/gegl some time ago (see ports/155183).

Fix: I blatantly copied the version check from graphics/gegl/files/patch-tools_exp_combine.cpp
How-To-Repeat: 	try to build graphviz on 8.2-RELEASE
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-20 18:40:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2011-05-20 20:55:24 UTC
State Changed
From-To: open->feedback


I build grphviz without your patch on 8.2-PRERELEASE 

$ make -V OSVERSION 
802500 

Please verify ... 
Do you use a non standard compiler?
Comment 3 R.Mahmatkhanov 2011-05-20 21:32:54 UTC
log2() is available in -stable since 802502, so it should be something like that 
(taken from gegl patch):

#if __FreeBSD_version <= 704100 ||
    (__FreeBSD_version >= 800000 && __FreeBSD_version < 802502) ||
    (__FreeBSD_version >= 900000 && __FreeBSD_version < 900027

-- 
Regards,
Ruslan
Comment 4 Jimmy Olgeni freebsd_committer freebsd_triage 2011-05-21 09:27:54 UTC
Hi,

> Do you use a non standard compiler?

I get the same problem with 8.2-RELEASE tinderboxes, but it only 
happens on amd64. i386 works fine, 8.2-STABLE on amd64 works fine too 
(on a "live" system, not tinderbox, as I'm only building for 
releases).

Hope this helps.

regards,

   Jimmy
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2011-05-21 09:57:21 UTC
State Changed
From-To: feedback->analyzed


I can reproduce the problem on amd64 but not on i386.
Comment 6 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2011-05-21 10:04:14 UTC
> I can reproduce the problem on amd64 but not on i386.

Jugdging from
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/freebsd-versions.html
8.2-RELEASE is OSVERSION 802000 and does not have log2 (that was added
in 802502). My 8.2 machines (amd64 and i386) are running -RELEASE,
report OSVERSION as 802000 and do not have log2.

Regards,
Christoph

-- 
Spare Space
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-05-21 15:10:28 UTC
dinoex      2011-05-21 14:10:19 UTC

  FreeBSD ports repository

  Added files:
    graphics/graphviz/files patch-lib-ortho-trapezoid.c 
  Log:
  - fix build an amd64
  PR:             157217
  Submitted by:   Christoph Moench-Tegeder
  
  Revision  Changes    Path
  1.1       +14 -0     ports/graphics/graphviz/files/patch-lib-ortho-trapezoid.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Dirk Meyer freebsd_committer freebsd_triage 2011-05-22 04:32:50 UTC
State Changed
From-To: analyzed->closed

committed, thanks.
Comment 9 Fedor Dikarev 2011-06-14 09:24:47 UTC
I've got FreeBSD 7.4 with version 704101, so that patch doesn't work for
me and I had to change
> if __FreeBSD_version <= 704100
to
> if __FreeBSD_version <= 704101

after that all works fine.

-- 
Fedor Dikarev
Rambler Internet Holding
Comment 10 dfilter service freebsd_committer freebsd_triage 2011-06-14 18:21:36 UTC
dinoex      2011-06-14 17:21:23 UTC

  FreeBSD ports repository

  Modified files:
    graphics/graphviz/files patch-lib-ortho-trapezoid.c 
  Log:
  - patch needed for 704101
  PR:             157217
  Reported by:    Fedor Dikarev
  
  Revision  Changes    Path
  1.2       +1 -1      ports/graphics/graphviz/files/patch-lib-ortho-trapezoid.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"