Bug 157422 - net/rabbitmq port compilation error
Summary: net/rabbitmq port compilation error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-30 13:10 UTC by Antoine van Gelder
Modified: 2011-06-14 20:40 UTC (History)
0 users

See Also:


Attachments
file.diff (398 bytes, patch)
2011-05-30 13:10 UTC, Antoine van Gelder
no flags Details | Diff
rabbitmq-patch.txt (1.78 KB, text/plain)
2011-06-14 03:28 UTC, Steve Wills
no flags Details
rabbitmq-patch.txt.sig (287 bytes, application/octet-stream)
2011-06-14 03:28 UTC, Steve Wills
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine van Gelder 2011-05-30 13:10:09 UTC
Compiling rabbitmq fails with: 

--
erlc -I include -o ebin -Wall -v +debug_info -Duse_specs -pa ebin src/rabbit_networking.erl
src/rabbit_networking.erl:58: type hostname() undefined
src/rabbit_networking.erl:80: type ip_port() undefined
gmake: *** [ebin/rabbit_networking.beam] Error 1
*** Error code 1

Stop in /usr/ports/net/rabbitmq.

Fix: The problem is being caused by missing type declarations for hostname/0 and ip_port/0 in src/rabbitmq_networking.erl

It looks like the problem has already been fixed in the rabbitmq mercurial repository.

The attached patch sorts it out.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/net/rabbitmq
make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-30 13:10:19 UTC
Maintainer of net/rabbitmq,

Please note that PR ports/157422 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157422

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-30 13:10:21 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Phillip N. 2011-06-06 00:08:23 UTC
Hello Antonie,

What version of erlang have you installed?
Rabbitmq is compiling just fine in my enviroment, wich is freebsd 8.0 with
erlang 14B02 (erts-5.8.3)

If i apply your patch, then erlang shoots this:
src/rabbit_networking.erl:54: type hostname() already defined

Thanks.

On Mon, May 30, 2011 at 8:10 AM, Edwin Groothuis <edwin@freebsd.org> wrote:

> Maintainer of net/rabbitmq,
>
> Please note that PR ports/157422 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157422
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>



-- 


__________________
Phillip Neumann
pneumann@gmail.com
Comment 4 Steve Wills freebsd_committer freebsd_triage 2011-06-14 02:16:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

I'll take it.
Comment 5 Steve Wills 2011-06-14 03:28:56 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

This may be a problem with different versions of erlang. Portmgr has
marked this port as broken, since it's failing in the ports build
cluster. I also found that it was broken. I think we should change the
dependency to require the latest erlang-lite and apply the patch. Please
see attached patch. Maintainer, would you approve that?

Thanks,
Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQEcBAEBAgAGBQJN9sdnAAoJEPXPYrMgexuhANEIAI9hmXRCa8/ZPYaGKjpSZdyM
g+POrmcItgkZeXUW7E1uJ81VGWoi5LD9iqx8VlD6OwPcvV1MYMzpZ4Nv667am9eu
zPyraioz0WggolufPzQ1wsR3WLMyzbm27NGVBQFXfrDkMCDHUD8L979FUQdUBMsw
inHVFFz+2Rsi/7KU1JPRQL5ney0cqS9uQeKesW7OrS92TViqbhUqKlnE4483pc/B
MLY3O5LJPQi3SpFJRtgZqfueGrEr2LkpiSTfYZTzBXo66Y3qD5D1QzrZejwdkwjd
HqrVSibtIqZjZNr9tbea9y4eWHM89UGGmlhJUpHIIqNGoWz+6T2yKaIr3OBtPWg=
=YntS
-----END PGP SIGNATURE-----
Comment 6 Phillip N. 2011-06-14 18:44:27 UTC
Hi Steve.

Sorry guys, I had erlan r14b02 and worked fine... didnt realize the erlang
port was updated..

Sure, please do the commit!

byebye

On Mon, Jun 13, 2011 at 10:28 PM, Steve Wills <steve@mouf.net> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> This may be a problem with different versions of erlang. Portmgr has
> marked this port as broken, since it's failing in the ports build
> cluster. I also found that it was broken. I think we should change the
> dependency to require the latest erlang-lite and apply the patch. Please
> see attached patch. Maintainer, would you approve that?
>
> Thanks,
> Steve
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (FreeBSD)
>
> iQEcBAEBAgAGBQJN9sdnAAoJEPXPYrMgexuhANEIAI9hmXRCa8/ZPYaGKjpSZdyM
> g+POrmcItgkZeXUW7E1uJ81VGWoi5LD9iqx8VlD6OwPcvV1MYMzpZ4Nv667am9eu
> zPyraioz0WggolufPzQ1wsR3WLMyzbm27NGVBQFXfrDkMCDHUD8L979FUQdUBMsw
> inHVFFz+2Rsi/7KU1JPRQL5ney0cqS9uQeKesW7OrS92TViqbhUqKlnE4483pc/B
> MLY3O5LJPQi3SpFJRtgZqfueGrEr2LkpiSTfYZTzBXo66Y3qD5D1QzrZejwdkwjd
> HqrVSibtIqZjZNr9tbea9y4eWHM89UGGmlhJUpHIIqNGoWz+6T2yKaIr3OBtPWg=
> =YntS
> -----END PGP SIGNATURE-----
>



-- 


__________________
Phillip Neumann
pneumann@gmail.com
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-06-14 20:34:58 UTC
swills      2011-06-14 19:34:50 UTC

  FreeBSD ports repository

  Modified files:
    net/rabbitmq         Makefile 
  Added files:
    net/rabbitmq/files   patch-src-rabbit_networking-erl 
  Log:
  - Fix build
  
  PR:             ports/157422
  Submitted by:   Antoine van Gelder <antoine@artifactual.org.za>
  Approved by:    Phillip Neumann <pneumann@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.22      +3 -5      ports/net/rabbitmq/Makefile
  1.1       +13 -0     ports/net/rabbitmq/files/patch-src-rabbit_networking-erl (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Steve Wills freebsd_committer freebsd_triage 2011-06-14 20:36:47 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!