-Update to 0.43 Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->perl perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Maintainer of www/p5-WWW-Contact, Please note that PR ports/157436 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157436 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: perl->culot I'll take it.
I approve this patch. Perhaps this time my approval will get through. Yahoo mail keeps getting blocked. :-( Fred ----- Original Message ---- From: Edwin Groothuis <edwin@FreeBSD.org> To: sailorfred@yahoo.com Cc: bug-followup@FreeBSD.org Sent: Mon, May 30, 2011 1:50:26 PM Subject: Re: ports/157436: [update] www/p5-WWW-Contact to 0.43 Maintainer of www/p5-WWW-Contact, Please note that PR ports/157436 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157436 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
Hi Ryan and Fred, thanks for submitting and reviewing this patch. However I have some suggestions to make and I have prepared an updated patch you might want to consider: http://people.freebsd.org/~culot/files/p5-WWW-Contact.diff Here are the modifications I applied: - I used the CPAN:USER macro for MASTER_SITE_SUBDIR - I added the license (same as for Perl) - I added the 2 following dependencies: 1) p5-HTML-Parser to get HTML::Entities, this was already a dependency for p5-HTML-Tree but I believe it is better to mention it explicitely 2) p5-Net-DNS to get Net::DNS::Resolver which seems to be a new dependency according to the vendor's changelog You can find the tinderbox log corresponding to my patch here: http://people.freebsd.org/~culot/tinderbox/8.2-FreeBSD/p5-WWW-Contact-0.43.log If you approve the changes I made then I will commit the updated patch. Thanks, Frederic
Frederic, Thank you, this looks good. -r
Thanks very much, those look great. I approve the revised patches. Fred ----- Original Message ---- From: Frederic Culot <culot@FreeBSD.org> To: bug-followup@FreeBSD.org; Fred Cox <sailorfred@yahoo.com>; Ryan Steinmetz <rpsfa@rit.edu> Sent: Sun, June 5, 2011 1:53:23 AM Subject: Re: ports/157436: [update] www/p5-WWW-Contact to 0.43 Hi Ryan and Fred, thanks for submitting and reviewing this patch. However I have some suggestions to make and I have prepared an updated patch you might want to consider: http://people.freebsd.org/~culot/files/p5-WWW-Contact.diff Here are the modifications I applied: - I used the CPAN:USER macro for MASTER_SITE_SUBDIR - I added the license (same as for Perl) - I added the 2 following dependencies: 1) p5-HTML-Parser to get HTML::Entities, this was already a dependency for p5-HTML-Tree but I believe it is better to mention it explicitely 2) p5-Net-DNS to get Net::DNS::Resolver which seems to be a new dependency according to the vendor's changelog You can find the tinderbox log corresponding to my patch here: http://people.freebsd.org/~culot/tinderbox/8.2-FreeBSD/p5-WWW-Contact-0.43.log If you approve the changes I made then I will commit the updated patch. Thanks, Frederic
culot 2011-06-05 20:21:34 UTC FreeBSD ports repository Modified files: www/p5-WWW-Contact Makefile distinfo Log: - Update to 0.43 [1] - Add missing dependencies - Make use of the CPAN:USER macro - Add LICENSE Changes: http://search.cpan.org/dist/WWW-Contact/Changes PR: ports/157436 [1] Submitted by: Ryan Steinmetz <rpsfa@rit.edu> Approved by: Fred Cox <sailorfred@yahoo.com> (maintainer) Revision Changes Path 1.4 +8 -3 ports/www/p5-WWW-Contact/Makefile 1.5 +2 -2 ports/www/p5-WWW-Contact/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!