Bug 157469 - textproc/expat2 provides the incorrect upstream patch for CVE-2009-3560
Summary: textproc/expat2 provides the incorrect upstream patch for CVE-2009-3560
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-31 18:50 UTC by Todd Rinaldo
Modified: 2011-08-29 15:40 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Todd Rinaldo 2011-05-31 18:50:08 UTC
textproc/expat2/files/patch-xmlparse.c is incomplete. It does not match the upstream patch provided for this at:
http://expat.cvs.sourceforge.net/viewvc/expat/expat/lib/xmlparse.c?r1=1.165&r2=1.166&view=patch

As a result, the test suite for perl's XML::Parser is universally failing on Free BSD:
http://www.cpantesters.org/distro/X/XML-Parser.html#XML-Parser-2.40_01?grade=1&perlmat=1&patches=1&oncpan=2&distmat=3&perlver=ALL&osname=ALL&version=2.40_01

This is being tracked in RT for XML::Parser via https://rt.cpan.org/Ticket/Display.html?id=55729

I plan to TODO these tests for Free BSD, referencing this PR until the problem is fixed.

Fix: 

Change textproc/expat2/files/patch-xmlparse.c  to match upstream:

http://expat.cvs.sourceforge.net/viewvc/expat/expat/lib/xmlparse.c?r1=1.165&r2=1.166&view=patch
How-To-Repeat: 1. install textproc/expat2
2. wget/unzip http://search.cpan.org/CPAN/authors/id/C/CH/CHORNY/XML-Parser-2.40.tar.gz
3. perl Makefile.PL 
4. gmake test
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-05-31 18:50:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kuriyama

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-08-29 15:33:35 UTC
kuriyama    2011-08-29 14:33:26 UTC

  FreeBSD ports repository

  Modified files:
    textproc/expat2      Makefile 
    textproc/expat2/files patch-xmlparse.c 
  Log:
  Apply updated (correct) fix for xmlparse.c (r1.166 in expat CVS).
  
  PR:             ports/157469
  Submitted by:   Todd Rinaldo <toddr@cpanel.net>
  
  Revision  Changes    Path
  1.37      +1 -1      ports/textproc/expat2/Makefile
  1.2       +12 -10    ports/textproc/expat2/files/patch-xmlparse.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jun Kuriyama freebsd_committer freebsd_triage 2011-08-29 15:33:36 UTC
State Changed
From-To: open->closed

Committed, thanks!