Bug 157605 - [PATCH] databases/postgis: enable GUI for shp2pgsql loader
Summary: [PATCH] databases/postgis: enable GUI for shp2pgsql loader
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-04 12:50 UTC by Rainer Hurling
Modified: 2011-07-01 07:30 UTC (History)
0 users

See Also:


Attachments
file.diff (1.04 KB, patch)
2011-06-04 12:50 UTC, Rainer Hurling
no flags Details | Diff
patch_v3.txt (1.67 KB, text/plain)
2011-06-24 15:35 UTC, Rainer Hurling
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2011-06-04 12:50:07 UTC
databases/postgis builds PostGIS itself, but also the command line tool version of the loader 'shp2pgsql', but not the GUI version. The GUI version can be used as standalone or better within PgAdmin3 (databases/pgadmin3) to directly convert shapefiles and load them into an open PostgreSQL database.

To be able to recognize 'shp2pgsql-gui', PgAdmin3 on FreeBSD also needs an entry in its plugins.ini file. I will submit a PR for it when the PostGIS port installs the GUI version.

/usr/local/share/pgadmin3/plugins.ini:
;
; PostGIS shp2pgsql-gui (Unix):
;
Title=PostGIS Shapefile and DBF loader
Command="$$PGBINDIR/shp2pgsql-gui" -h $$HOSTNAME -p $$PORT -U $$USERNAME -d $$DATABASE
Description=Open a PostGIS ESRI Shapefile or Plain dbf loader to the current database.
KeyFile=$$PGBINDIR/shp2pgsql-gui
Platform=unix
ServerType=postgresql
Database=Yes
SetPassword=Yes

Fix: The following patch should also install the GUI version 'shp2pgsl'. In addition I removed two unnecessary whitespaces.



Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/databases/postgis
make clean && make install


After that there is no 'shp2pgsql-gui' installed in /usr/local/bin/.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-04 12:50:15 UTC
Maintainer of databases/postgis,

Please note that PR ports/157605 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157605

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-04 12:50:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Wen Heping freebsd_committer freebsd_triage 2011-06-10 01:25:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wen

I'll take it.
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2011-06-24 15:35:16 UTC
After some offline testing and discussion with wen@ here is another 
patch. It respects gnome and it makes building the gui an option.
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-07-01 07:23:09 UTC
wen         2011-07-01 06:22:55 UTC

  FreeBSD ports repository

  Modified files:
    databases/postgis    Makefile pkg-plist 
  Log:
  - Enable GUI for shp2pgsql loader
  
  PR:             ports/157605
  Submitted by:   Rainer Hurling <rhurlin@gwdg.de>
  Approved by:    maintainer(timeout, >20 days)
  
  Revision  Changes    Path
  1.62      +15 -2     ports/databases/postgis/Makefile
  1.15      +1 -0      ports/databases/postgis/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Wen Heping freebsd_committer freebsd_triage 2011-07-01 07:24:22 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!