Bug 157617 - [PATCH] Makefile cleanup and configure argument fixes to x11-wm/fvwm2
Summary: [PATCH] Makefile cleanup and configure argument fixes to x11-wm/fvwm2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-04 23:20 UTC by Niclas Zeising
Modified: 2011-06-05 06:40 UTC (History)
0 users

See Also:

Attachments
fvwm2.Makefile.diff (3.46 KB, patch)
2011-06-04 23:20 UTC, Niclas Zeising 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas Zeising 2011-06-04 23:20:08 UTC 
	The arguments to sent to the configure script for x11-wm/fvwm2 are partly broken. There are several arguments passed that does not exist anymore (generating a warning from configure) and at least the dependency on png is picked up regardless of the option. There is also a hidden dependency on graphics/librsvg2 if that port is installed. Lastly, the support for multibyte characters is either removed completely or always turned on, so that option is removed.

Fix: Attached patch cleans up the configure arguments and properly disables png when needed. It also adds an explicit optional dependency on librsvg2, as well as optional explicit dependencies on GNOME (version 1) and imlib. There might be reason to just rip GNOME 1 and imlib support out of the port, since especially GNOME 1 is hardly ever used.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-04 23:20:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->cy

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-06-05 06:30:25 UTC 
cy          2011-06-05 05:30:11 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/fvwm2-devel   Makefile 
  Added files:
    x11-wm/fvwm2-devel/files patch-configure.ac 
  Log:
  Configuration improvements:
  
  - Add knobs for SVG and IMLIB.
  - Remove redundant MULTIBYTE option.
  - Add includes to args passed to configure script.
  - Fix libXcursor detection.
  
  PR:             157617 and 157618
  Submitted by:   Niclas Zeising <niclas.zeising@gmail.com>
  
  Revision  Changes    Path
  1.125     +29 -16    ports/x11-wm/fvwm2-devel/Makefile
  1.1       +11 -0     ports/x11-wm/fvwm2-devel/files/patch-configure.ac (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-06-05 06:31:28 UTC 
cy          2011-06-05 05:31:20 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/fvwm2         Makefile 
  Added files:
    x11-wm/fvwm2/files   patch-configure.ac 
  Log:
  Configuration improvements:
  
  - Add knobs for SVG and IMLIB.
  - Remove redundant MULTIBYTE option.
  - Add includes to args passed to configure script.
  - Fix libXcursor detection.
  
  PR:             157617 and 157618
  Submitted by:   Niclas Zeising <niclas.zeising@gmail.com>
  
  Revision  Changes    Path
  1.84      +29 -16    ports/x11-wm/fvwm2/Makefile
  1.1       +11 -0     ports/x11-wm/fvwm2/files/patch-configure.ac (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2011-06-05 06:37:57 UTC 
State Changed
From-To: open->closed

Committed. Thanks for the patch.