This port uses pkg-install to create new users instead of using USERS= and GROUPS= XXXXXXXXXX Because it's marked BROKEN, I haven't Tinderbox checked it. Balwinder, please would you incorporate this patch into your fix? XXXXXXXXXX Fix: - Use USERS and GROUPS Submitted by: Chris Rees (utisoft@gmail.com) -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.--Rd6Kal26YRED0LUnbMaEH8EGfVVCmwr2GACym0piTe7ChGRD Content-Type: text/plain; name="yate-devel.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="yate-devel.patch" Index: Makefile =================================================================== RCS file: /exports/cvsroot-freebsd/ports/net/yate-devel/Makefile,v retrieving revision 1.16 diff -u -r1.16 Makefile --- Makefile 20 Jan 2011 17:38:16 -0000 1.16 +++ Makefile 31 May 2011 19:37:36 -0000 @@ -47,6 +47,8 @@ H323 "H323 software channel/protocol support" on \ FAX "Fax software channel/driver support" off +USERS= ${PORTNAME} +GROUPS= ${USERS} DOCSDIR= ${LOCALBASE}/share/doc/yate PLIST_SUB= BRISTUFF="@comment " PLIST_SUB+= VERSION=${PORTVERSION:S/.p2//} Index: pkg-install =================================================================== RCS file: pkg-install diff -N pkg-install --- pkg-install 23 Sep 2007 12:34:40 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,35 +0,0 @@ -#!/bin/sh -# $FreeBSD: ports/net/yate-devel/pkg-install,v 1.1 2007/09/23 12:34:40 edwin Exp $ -# - -if [ "$2" != "PRE-INSTALL" ]; then - exit 0 -fi - -YATE_USER=yate -YATE_GROUP=${YATE_USER} -YATE_UID=204 -YATE_GID=${YATE_UID} - -if ! pw groupshow "${YATE_GROUP}" 2>/dev/null 1>&2; then - if pw groupadd ${YATE_GROUP} -g ${YATE_GID}; then - echo "Added group \"${YATE_GROUP}\"." - else - echo "Adding group \"${YATE_GROUP}\" failed..." - exit 1 - fi -fi - -if ! pw usershow "${YATE_USER}" 2>/dev/null 1>&2; then - if pw useradd ${YATE_USER} -u ${YATE_UID} -g ${YATE_GROUP} -h - \ - -s "/sbin/nologin" -d "/nonexistent" \ - -c "Yate Telephoney Server"; \ - then - echo "Added user \"${YATE_USER}\"." - else - echo "Adding user \"${YATE_USER}\" failed..." - exit 1 - fi -fi - -exit 0
Responsible Changed From-To: freebsd-ports-bugs->pgollucci pgollucci@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of net/yate-devel, Please note that PR ports/157630 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157630 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Sorry! Should have mentioned that pkg-install has been removed. Chris
The patch seems good; I approve it. -- Balwinder S "bdheeman" Dheeman (http://werc.homelinux.net/contact/)
Responsible Changed From-To: pgollucci->crees Invalid autoassignment
Responsible Changed From-To: crees->freebsd-ports-bugs To pool to correct assign message
Responsible Changed From-To: freebsd-ports-bugs->crees Invalid autoassignment to pgollucci
State Changed From-To: feedback->open Maintainer has approved.
Hey, The port appears to be marked BROKEN= does not compile -- please would you investigate and fix it? If you really don't have the time right now I'll do it for you, please let me know. I'll incorporate your fixes into my patch. I must point out that perhaps this is a nice candidate for deprecation -- net/yate appears more up to date? What do you think? Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
On 07/08/2011 01:52 AM, Chris Rees wrote: > The port appears to be marked BROKEN= does not compile -- please would > you investigate and fix it? Yes, I know the current state of this port. I actually developed/submitted this port as a snapshot of SVN, just because the upstream people are quick enough to fix most of the bugs and, or feature requests in their SVN repository and they mention these things on the mailing list as well. > If you really don't have the time right now I'll do it for you, please > let me know. I'll incorporate your fixes into my patch. Sure, you may skip/omit most of the changes I made except for the fixes related to security e.g. the daemon must not run as root. Please do have a look at https://github.com/vir/yate/wiki also. I stopped submitting/sending updates to both the yate and yate-devel ports long ago when either the people having commit rights were overly busy or did not bother to look at my submissions. > I must point out that perhaps this is a nice candidate for deprecation > -- net/yate appears more up to date? > > What do you think? Though the current stable version of yate is 3.3.2 was released on April 12, 2011 but, their SVN repository contains many fixes since then. -- Balwinder S "bdheeman" Dheeman (http://werc.homelinux.net/contact/)
I'm sorry you've not had much luck with getting your updates committed. Please would you send me links to PRs that have been neglected by us? I'll commit them for you if you like. Chris On 8 Jul 2011 01:48, "Balwinder S Dheeman" <bdheeman@gmail.com> wrote: > On 07/08/2011 01:52 AM, Chris Rees wrote: >> The port appears to be marked BROKEN= does not compile -- please would >> you investigate and fix it? > > Yes, I know the current state of this port. I actually > developed/submitted this port as a snapshot of SVN, just because the > upstream people are quick enough to fix most of the bugs and, or feature > requests in their SVN repository and they mention these things on the > mailing list as well. > >> If you really don't have the time right now I'll do it for you, please >> let me know. I'll incorporate your fixes into my patch. > > Sure, you may skip/omit most of the changes I made except for the fixes > related to security e.g. the daemon must not run as root. > > Please do have a look at https://github.com/vir/yate/wiki also. > > I stopped submitting/sending updates to both the yate and yate-devel > ports long ago when either the people having commit rights were overly > busy or did not bother to look at my submissions. > >> I must point out that perhaps this is a nice candidate for deprecation >> -- net/yate appears more up to date? >> >> What do you think? > > Though the current stable version of yate is 3.3.2 was released on April > 12, 2011 but, their SVN repository contains many fixes since then. > > -- > Balwinder S "bdheeman" Dheeman > (http://werc.homelinux.net/contact/) >
On 07/08/2011 05:42 PM, Chris Rees wrote: > > I'm sorry you've not had much luck with getting your updates > committed. Please would you send me links to PRs that have been > neglected by us? I'll commit them for you if you like. > I think, all those PRs are stale now. Hence we need not commit them. I managed to provide most of the port I maintained and, or sent updates for over a web-server run on a dynamic domestic connection, see http://anu.homelinux.net/ports#yate-devel -- Balwinder S "bdheeman" Dheeman (http://werc.homelinux.net/contact/)
crees 2011-07-08 17:25:53 UTC FreeBSD ports repository Modified files: net/yate-devel Makefile Removed files: net/yate-devel pkg-install Log: Use USERS and GROUPS PR: ports/157630 Submitted by: crees (me) Approved by: rene (mentor, implicit), maintainer Revision Changes Path 1.17 +2 -3 ports/net/yate-devel/Makefile 1.2 +0 -35 ports/net/yate-devel/pkg-install (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
On 8 July 2011 15:52, Balwinder S Dheeman <bdheeman@gmail.com> wrote: > On 07/08/2011 05:42 PM, Chris Rees wrote: >> >> I'm sorry you've not had much luck with getting your updates committed. >> Please would you send me links to PRs that have been neglected by us? I'll >> commit them for you if you like. >> > > I think, all those PRs are stale now. Hence we need not commit them. > > I managed to provide most of the port I maintained and, or sent updates for > over a web-server run on a dynamic domestic connection, see > http://anu.homelinux.net/ports#yate-devel Yes, but if there are stale PRs then they should be closed. A cursory search of the PR database for Dheeman comes up with ~8 PRs, all of which have been closed. If you have any others outstanding please let me know and I'll close them too. Chris
State Changed From-To: open->closed Committed.