Bug 157845 - editors/vim lacks python and other features when using WITH_VIM_OPTIONS
Summary: editors/vim lacks python and other features when using WITH_VIM_OPTIONS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: David E. O'Brien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 18:10 UTC by Eir Nym
Modified: 2011-06-20 18:40 UTC (History)
0 users

See Also:

Attachments
file.diff (396 bytes, patch)
2011-06-13 18:10 UTC, Eir Nym 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eir Nym 2011-06-13 18:10:08 UTC 
When I compile vim(1) with options, it will be built with another options.
For example, I have WITHOUT_NLS and WITH_VIM_OPTIONS in my make.conf(5), and setted options according following configuration, no Python support will be in vim(1):
# make show-options
===> The following configuration options are available for vim-7.3.121:
     PERL=on "Enable Perl interpreter"
     PYTHON=on "Enable Python interpreter"
     RUBY=on "Enable Ruby interpreter"
     TCL=on "Enable TCL interpreter"
     LUA=off "Enable lua interpreter"
     LANG=on "VIm Translations"
     CSCOPE=on "Enable cscope"
     EXUBERANT_CTAGS=on "Use exctags instead of ctags"
     X11=off "X11 support (required for options below)"
     X11_ONLY=off "CLI-only Vim, but with basic X11 support"
     XTERM_SAVE=off "Restore xterm screen after exit"
     ATHENA=off "Athena GUI"
     GTK2=off "GTK2 GUI"
     GNOME2=off "Gnome2 GUI"
     MOTIF=off "Motif GUI"
===> Use 'make config' to modify these settings
# make -V MAKE_ARGS
CONF_ARGS="--prefix=/usr/local --with-tlib=termlib " CONF_OPT_FEAT="--with-features=big" CONF_OPT_CSCOPE="--enable-cscope" CONF_OPT_PERL="--enable-perlinterp" CONF_OPT_TCL="--enable-tclinterp --with-tclsh=""" CONF_OPT_GUI="--enable-gui=no --without-x" CONF_OPT_MULTIBYTE="--enable-multibyte --enable-fontset --enable-xim"

Fix: Apply following patch and you can see correct MAKE_ARGS and dependencies:

#make -V MAKE_ARGS
CONF_ARGS="--prefix=/usr/local --with-tlib=termlib " CONF_OPT_PYTHON="--enable-pythoninterp" CONF_OPT_RUBY="--enable-rubyinterp" CONF_OPT_FEAT="--with-features=big" CONF_OPT_CSCOPE="--enable-cscope" CONF_OPT_PERL="--enable-perlinterp" CONF_OPT_TCL="--enable-tclinterp --with-tclsh="tclsh8.5"" CONF_OPT_GUI="--enable-gui=no --without-x" CONF_OPT_MULTIBYTE="--enable-multibyte --enable-fontset --enable-xim"

Patch attached with submission follows:
How-To-Repeat: # echo WITH_VIM_OPTIONS=yes >> /etc/make.conf
# cd /usr/ports/editors/vim && make config
# make -V MAKE_ARGS
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-13 18:10:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 David E. O'Brien freebsd_committer freebsd_triage 2011-06-20 18:26:23 UTC 
State Changed
From-To: open->closed

Committed.  Thanks for the bug report! 
I changed the location of the include a little from the PR's patch. 
Please double check and let me know if it doesn't work for you. 

Again thank you for the well formed PR with easy reproduction case.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-06-20 18:38:13 UTC 
obrien      2011-06-20 17:38:00 UTC

  FreeBSD ports repository

  Modified files:
    editors/vim          Makefile 
  Log:
  Include bsd.port.options.mk.
  
  PR:             157845
  Submitted by:   Eir Nym <eirnym@gmail.com>
  
  Revision  Changes    Path
  1.385     +1 -0      ports/editors/vim/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"