Bug 157854 - dns/curvedns should use USERS and GROUPS
Summary: dns/curvedns should use USERS and GROUPS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 00:40 UTC by Leo Vandewoestijne
Modified: 2011-07-19 18:53 UTC (History)
0 users

See Also:

Attachments
curvedns.patch (2.21 KB, patch)
2011-06-14 00:40 UTC, Leo Vandewoestijne 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2011-06-14 00:40:08 UTC 
PR 157577 reported the curvedns port uses pkg-install to create new users,
instead of using USERS= and GROUPS=
This patch merges the suggested fix, includes my suggested corrections,
and includes an additional hint in the pkg-message.

Fix: NOTE: pkg-install should be deleted!
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-14 00:40:23 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

pgollucci@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer freebsd_triage 2011-06-23 17:44:19 UTC 
Responsible Changed
From-To: pgollucci->crees

Invalid autoassignment
Comment 3 Chris Rees freebsd_committer freebsd_triage 2011-06-23 17:51:25 UTC 
State Changed
From-To: open->feedback

Ask for maintainer fix.
Comment 4 Chris Rees freebsd_committer freebsd_triage 2011-06-23 17:51:29 UTC 
Er... what's this I spy in pkg-deinstall.in ?

rm -rf %%PREFIX%%/etc/curvedns ?

Please write some proper handling of config files into pkg-plist; 
there's guidance in the Porter's Handbook.

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 5 Chris Rees freebsd_committer freebsd_triage 2011-07-04 19:32:45 UTC 
Hi,

I've fixed the config files issue, please let me know if you'd like to 
add anything.

Chris

http://www.bayofrum.net/~crees/patches/uids/dns-curvedns.patch

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-07-19 18:44:44 UTC 
crees       2011-07-19 17:44:30 UTC

  FreeBSD ports repository

  Modified files:
    dns/curvedns         Makefile pkg-plist 
    dns/curvedns/files   pkg-message.in 
  Removed files:
    dns/curvedns/files   pkg-deinstall.in pkg-install.in 
  Log:
  - Use USERS and GROUPS
  - Stop clobbering config files on deinstall
  
  PR:             ports/157854
  Submitted by:   Leo Vandewoestijne <freebsd@dns-lab.com>
  Approved by:    rene (mentor, implicit), maintainer timeout (14 days)
  
  Revision  Changes    Path
  1.4       +10 -13    ports/dns/curvedns/Makefile
  1.2       +0 -6      ports/dns/curvedns/files/pkg-deinstall.in (dead)
  1.2       +0 -25     ports/dns/curvedns/files/pkg-install.in (dead)
  1.2       +2 -0      ports/dns/curvedns/files/pkg-message.in
  1.2       +11 -1     ports/dns/curvedns/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Chris Rees freebsd_committer freebsd_triage 2011-07-19 18:53:12 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!