Two binaries in argus-clients are not compiled when the make config option MYSQL is changed from the default ON to OFF. The flag USE_MYSQL is not passed, so the binaries bin/rasql and bin/rasqlinsert are not created. This causes the ports installation script to fail later when attempting to install the non-existent binaries. Fix: Patch: # diff -ruN Makefile.old Makefile How-To-Repeat: Procedure: # cd /usr/ports/net-mgmt/argus3-clients # make config - uncheck MYSQL default from ON to OFF # make install Result: ===> Installing for argus-clients-3.0.4.1 ===> Generating temporary packing list ===> Checking if net-mgmt/argus3-clients already installed install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/ra /usr/local/bin/ra install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rabins /usr/local/bin/rabins install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/racluster /usr/local/bin/racluster install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/racount /usr/local/bin/racount install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/radump /usr/local/bin/radump install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rafilteraddr /usr/local/bin/rafilteraddr install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rahisto /usr/local/bin/rahisto install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/ralabel /usr/local/bin/ralabel install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/ranonymize /usr/local/bin/ranonymize install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rapath /usr/local/bin/rapath install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rapolicy /usr/local/bin/rapolicy install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/raservices /usr/local/bin/raservices install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rasort /usr/local/bin/rasort install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rasplit /usr/local/bin/rasplit install -s -o root -g wheel -m 555 /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rasql /usr/local/bin/rasql install: /usr/ports/net-mgmt/argus3-clients/work/argus-clients-3.0.4.1/bin/rasql: No such file or directory *** Error code 71 Stop in /usr/ports/net-mgmt/argus3-clients. *** Error code 1 Stop in /usr/ports/net-mgmt/argus3-clients.
Maintainer of net-mgmt/argus3-clients, Please note that PR ports/157905 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157905 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->jlaffaye I'll take it.
Hello. I approve this patch. --=20 Demin Alexander / Network Administrator Group of companies Spectrum / tel. (+7 495) 995-8999 Russia, Moscow, 125009, Strastnoy blvr. 8 Web: http://www.spectrum.ru/
This is a more complete patch including a fix for pkg-plist which will = also allow the package to build correctly: # diff -uN Makefile.old Makefile --- Makefile.old 2011-06-15 15:27:33.000000000 +0000 +++ Makefile 2011-06-15 17:58:08.000000000 +0000 @@ -34,6 +34,9 @@ =20 .if defined(WITH_MYSQL) USE_MYSQL=3D yes +PLIST_SUB+=3D MYSQL=3D"" +.else +PLIST_SUB+=3D MYSQL=3D"@comment " .endif =20 .if defined(WITH_GEOIP) @@ -51,10 +54,15 @@ do-install: .for i in ra rabins racluster racount radump rafilteraddr \ rahisto ralabel ranonymize rapath rapolicy \ - raservices rasort rasplit rasql rasqlinsert rastream \ - rastrip ratemplate ratimerange ratop ratree rauserdata + raservices rasort rasplit rastream rastrip \ + ratemplate ratimerange ratop ratree rauserdata ${INSTALL_PROGRAM} ${WRKSRC}/bin/$i ${PREFIX}/bin/$i .endfor +.if defined(WITH_MYSQL) +.for i in rasql rasqlinsert + ${INSTALL_PROGRAM} ${WRKSRC}/bin/$i ${PREFIX}/bin/$i +.endfor +.endif .for i in radark ragraph rahosts raports ${INSTALL_SCRIPT} ${WRKSRC}/bin/$i ${PREFIX}/bin/$i .endfor # diff -uN pkg-plist.old pkg-plist --- pkg-plist.old 2011-06-15 17:58:15.000000000 +0000 +++ pkg-plist 2011-06-15 17:58:41.000000000 +0000 @@ -16,8 +16,8 @@ bin/raservices bin/rasort bin/rasplit -bin/rasql -bin/rasqlinsert +%%MYSQL%%bin/rasql +%%MYSQL%%bin/rasqlinsert bin/rastream bin/rastrip bin/ratemplate=
State Changed From-To: feedback->closed Committed. Thanks!
jlaffaye 2011-06-16 16:53:21 UTC FreeBSD ports repository Modified files: net-mgmt/argus3-clients Makefile pkg-plist Log: Fix installation and plist when the MYSQL option is off PR: ports/157905 Submitted by: Derek Brost <derek.brost@eprotex.com> Approved by: Alexander Demin <support@spectrum.ru> (maintainer), bapt (mentor) Revision Changes Path 1.7 +9 -1 ports/net-mgmt/argus3-clients/Makefile 1.3 +2 -2 ports/net-mgmt/argus3-clients/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"