Bug 157914 - [patch] keymaps in textproc/ibus is incorrect
Summary: [patch] keymaps in textproc/ibus is incorrect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 22:50 UTC by buganini
Modified: 2011-06-28 18:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.24 KB, patch)
2011-06-15 22:50 UTC, buganini
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description buganini 2011-06-15 22:50:09 UTC
The ${WRKSRC}/data/keymaps/common use linux's `xmodmap -pke` value - 8,
the -8 is hardcoded in every of ibus' bridge,
you can `grep -R keycode *|grep 8` in their source to find it.

And FreeBSD's xmodmap is differ from linux's:
http://security-hole.info/~buganini/linux.xmodmap.txt
http://security-hole.info/~buganini/freebsd.xmodmap.txt
http://security-hole.info/~buganini/linux-freebsd.xmodmap.txt

this difference make some keys malfunction if a im engine is designed use keycode and ibus_keymap_lookup_keysym() instead of using keyval/keysym directly.

Known affected im engine:
ibus-chewing

Fix: Patch attached with submission follows:
How-To-Repeat: type something with ibus-chewing and try to use left arrow the move to previous phrase.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-15 22:50:28 UTC
Maintainer of textproc/ibus,

Please note that PR ports/157914 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157914

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-15 22:50:30 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Xin LI freebsd_committer freebsd_triage 2011-06-16 01:02:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->delphij

Take.
Comment 4 Henry Hu 2011-06-28 17:15:58 UTC
OK, I have tested the patch. Although I do not understand the method to use
ibus-chewing to input text which I want, I found that without the patch, the
left arrow behavior is strange, and with the patch, the behavior is more
natural. If the submitter can confirm that this patch works, I think it can
be committed.

-- 
Cheers,
Henry
Comment 5 Xin LI freebsd_committer freebsd_triage 2011-06-28 18:07:21 UTC
State Changed
From-To: feedback->open

Maintainer approved the patch
Comment 6 Xin LI freebsd_committer freebsd_triage 2011-06-28 18:15:41 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-06-28 18:15:52 UTC
delphij     2011-06-28 17:15:38 UTC

  FreeBSD ports repository

  Modified files:
    textproc/ibus        Makefile 
  Added files:
    textproc/ibus/files  patch-data-keymaps-common 
  Log:
  Add a workaround for a few keys to make them match with the FreeBSD keymap.
  
  Submitted by:   Kuan-Chung Chiu <buganini@gmail.com>
  PR:             ports/157914
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.17      +1 -0      ports/textproc/ibus/Makefile
  1.1       +28 -0     ports/textproc/ibus/files/patch-data-keymaps-common (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"