Bug 158610 - [patch] www/firefox: require cairo version with tee support
Summary: [patch] www/firefox: require cairo version with tee support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-03 15:50 UTC by Pan Tsu
Modified: 2011-07-04 18:30 UTC (History)
0 users

See Also:


Attachments
a.diff (710 bytes, patch)
2011-07-03 15:50 UTC, Pan Tsu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pan Tsu 2011-07-03 15:50:12 UTC
Fail early if a user didn't follow the right order[1]. It shouldn't happen
when installing/updating ports with portmaster et al.

With this patch cairo would be queried twice:
  - Mk/bsd.gecko.mk - USE_MOZILLA
  - www/firefox/Makefile - BUILD_DEPENDS
similar to NSPR.

[1] most recent example: http://forums.freebsd.org/showpost.php?p=139370&postcount=4

How-To-Repeat: 1. csup ports before 02 Mar 2011
2. install firefox
3. csup again to most recent date
4. update firefox by `make all deinstall install'

      $ make
      [..]
      ===>   Found cairo-1.10.2,1, but you need to upgrade to cairo>=1.10.2_1,1.
      *** Error code 1
Comment 1 Florian Smeets freebsd_committer freebsd_triage 2011-07-04 18:28:57 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-07-04 18:29:03 UTC
flo         2011-07-04 17:28:33 UTC

  FreeBSD ports repository

  Modified files:
    www/firefox          Makefile 
  Log:
  - require cairo>=1.10.2_1,1 to catch build failuers early
  
  The cairo dependancy is usually added by bsd.gecko.mk, but for firefox we need a
  spcific version.
  
  PR:             ports/158610
  Submitted by:   Pan Tsu <inyaoo@gmail.com>
  
  Revision  Changes    Path
  1.242     +2 -1      ports/www/firefox/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"