Bug 158702 - [patch] www/firefox-devel: prune -DFREEBSD cruft in js
Summary: [patch] www/firefox-devel: prune -DFREEBSD cruft in js
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 10:40 UTC by Pan Tsu
Modified: 2011-08-16 20:41 UTC (History)
0 users

See Also:

Attachments
a.diff (1.20 KB, patch)
2011-07-07 10:40 UTC, Pan Tsu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pan Tsu 2011-07-07 10:40:05 UTC 
I think the issue[1] with hidden pthread_attr_get_np is gcc specific.
pthread_np.h in config/system-headers should be enough to unhide it.

[1] http://docs.freebsd.org/cgi/mid.cgi?86mxposuzj.fsf

How-To-Repeat: 1. build with gcc45 and basegcc
2. nm -D /usr/local/lib/firefox/libxul.so | grep 'pthread.*attr'
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-08-07 07:57:01 UTC 
State Changed
From-To: open->feedback

There's no port firefox-aurora in the repository.  Can you be more 
specific about where this patch should be applied?
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2011-08-07 08:16:11 UTC 
State Changed
From-To: feedback->closed

Submitter's email address bounced.
Comment 3 Florian Smeets freebsd_committer freebsd_triage 2011-08-07 09:41:00 UTC 
State Changed
From-To: closed->open

This is actually a valid PR and i'm working on it. We have firefox-aurora 
in the gecko svn repo.
Comment 4 Florian Smeets freebsd_committer freebsd_triage 2011-08-16 20:41:51 UTC 
State Changed
From-To: open->closed

Committed. Thanks!