Bug 158716 - Turn APNG on by default in graphics/png
Summary: Turn APNG on by default in graphics/png
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 04:40 UTC by Mikhail T.
Modified: 2011-07-08 15:53 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2011-07-08 04:40:01 UTC 
	As discussed on ports@, changing to use APNG by default would
	allow Mozilla ports to build using the already installed libpng
	without any other ill effects.

	The only opponent of the change was ache@ (CC-ed), but even he
	was persuaded by the end of the discussion.

Fix: 

If the change does not coincide with a routine update of png,
	(1.5.4 was released today, for example) then PORTREVISION bump
	may be needed as well.

--- Makefile	23 Dec 2010 05:41:59 -0000	1.115
+++ Makefile	8 Jul 2011 03:06:32 -0000
@@ -32,5 +32,5 @@
 MANCOMPRESSED=	maybe
 
-OPTIONS=	APNG "Animated PNG support" Off
+OPTIONS=	APNG "Animated PNG support (required for Mozilla)" On
 
 .include <bsd.port.pre.mk>
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-08 04:40:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2011-07-08 12:49:23 UTC 
State Changed
From-To: open->feedback

I will look into this. 

There is much more to do that to toggle the option. 
Please wait for a new patch.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-07-08 14:27:29 UTC 
dinoex      2011-07-08 13:27:20 UTC

  FreeBSD ports repository

  Modified files:
    graphics/png         Makefile distinfo 
  Log:
  - enable option APNG
  PR:             158716
  Suggested by:   Mikhail T.
  
  - bump PORTREVISION
  - use compressed patch from original master
  - remove obsolte ghostscript hooks
  
  Revision  Changes    Path
  1.116     +11 -12    ports/graphics/png/Makefile
  1.59      +2 -2      ports/graphics/png/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2011-07-08 15:53:33 UTC 
State Changed
From-To: feedback->closed

committed, thanks.