Port is right now completely broken, and fails to execute. Add in Apache License. Add in dependencies. Add in wrapper script. (namebench looks for files in non-standard port locations for execution) Builds cleanly in Tinderbox.
Here is an updated patch that fixes having to have a wrapper script. By adding a symlink of /etc/namebench that points to /usr/local/share/namebench, the binary (namebench.py) runs without issue. Please ignore the previous patch. Thanks! This builds cleanly in Tinderbox. Index: Makefile =================================================================== RCS file: /home/jhelfman/ncvs/ports/dns/py-namebench/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- Makefile 25 Feb 2011 00:12:11 -0000 1.3 +++ Makefile 25 Jul 2011 16:28:33 -0000 @@ -6,33 +6,45 @@ # PORTNAME= namebench -PORTVERSION= 1.0 -PORTREVISION= 1 +PORTVERSION= 1.3.1 CATEGORIES= dns python MASTER_SITES= GOOGLE_CODE PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} +DISTNAME= ${PORTNAME}-${PORTVERSION}-source EXTRACT_SUFX= .tgz MAINTAINER= ports@FreeBSD.org COMMENT= An open-source DNS benchmark utility +LICENSE= ASL + +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}Jinja2>=2.5.5:${PORTSDIR}/devel/py-Jinja2 \ + ${PYTHON_PKGNAMEPREFIX}graphy>=1.0:${PORTSDIR}/graphics/py-graphy \ + ${PYTHON_PKGNAMEPREFIX}dnspython>=1.9.4:${PORTSDIR}/dns/py-dnspython \ + ${PYTHON_PKGNAMEPREFIX}httplib2>=0.6.0:${PORTSDIR}/www/py-httplib2 \ + ${PYTHON_PKGNAMEPREFIX}simplejson>=2.1.6:${PORTSDIR}/devel/py-simplejson + +.if !defined(WITHOUT_X11) +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}tkinter>=2.7.1:${PORTSDIR}/x11-toolkits/py-tkinter +.endif + MAKE_ENV+= NO_THIRD_PARTY=yes +WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} PORTDOCS= README.txt -USE_PYTHON= 2.5+ +USE_PYTHON= yes USE_PYDISTUTILS= yes PYDISTUTILS_INSTALLARGS+= --install-data=${PREFIX}/share NO_INSTALL_MANPAGES= yes -post-patch: - @${REINPLACE_CMD} '/windows/d' ${WRKSRC}/setup.py - post-install: .if !defined(NOPORTDOCS) @${INSTALL} -o ${DOCOWN} -g ${DOCGRP} -m 555 -d ${DOCSDIR} @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${DOCSDIR} .endif + ${LN} -s ${DATADIR} /etc/${PORTNAME} + .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /home/jhelfman/ncvs/ports/dns/py-namebench/distinfo,v retrieving revision 1.2 diff -u -r1.2 distinfo --- distinfo 25 Feb 2011 00:12:11 -0000 1.2 +++ distinfo 12 Jul 2011 04:04:40 -0000 @@ -1,2 +1,2 @@ -SHA256 (namebench-1.0.tgz) = 59af0fea2ce4cb52a3999115ecf77331150cd1ccae36e05e173680bb6d68611c -SIZE (namebench-1.0.tgz) = 2557100 +SHA256 (namebench-1.3.1-source.tgz) = 30ccf9e870c1174c6bf02fca488f62bba280203a0b1e8e4d26f3756e1a5b9425 +SIZE (namebench-1.3.1-source.tgz) = 1118505 Index: pkg-plist =================================================================== RCS file: /home/jhelfman/ncvs/ports/dns/py-namebench/pkg-plist,v retrieving revision 1.1 diff -u -r1.1 pkg-plist --- pkg-plist 25 Dec 2009 19:24:24 -0000 1.1 +++ pkg-plist 25 Jul 2011 16:24:59 -0000 @@ -1,52 +1,77 @@ bin/namebench.py %%PYTHON_SITELIBDIR%%/libnamebench/__init__.py -%%PYTHON_SITELIBDIR%%/libnamebench/base_ui.py -%%PYTHON_SITELIBDIR%%/libnamebench/benchmark.py -%%PYTHON_SITELIBDIR%%/libnamebench/benchmark_test.py -%%PYTHON_SITELIBDIR%%/libnamebench/better_webbrowser.py -%%PYTHON_SITELIBDIR%%/libnamebench/charts.py -%%PYTHON_SITELIBDIR%%/libnamebench/charts_test.py -%%PYTHON_SITELIBDIR%%/libnamebench/cli.py -%%PYTHON_SITELIBDIR%%/libnamebench/config.py -%%PYTHON_SITELIBDIR%%/libnamebench/conn_quality.py -%%PYTHON_SITELIBDIR%%/libnamebench/history_parser.py -%%PYTHON_SITELIBDIR%%/libnamebench/mocks.py -%%PYTHON_SITELIBDIR%%/libnamebench/nameserver.py -%%PYTHON_SITELIBDIR%%/libnamebench/nameserver_list.py -%%PYTHON_SITELIBDIR%%/libnamebench/nameserver_test.py -%%PYTHON_SITELIBDIR%%/libnamebench/selectors.py -%%PYTHON_SITELIBDIR%%/libnamebench/selectors_test.py -%%PYTHON_SITELIBDIR%%/libnamebench/tk.py -%%PYTHON_SITELIBDIR%%/libnamebench/util.py -%%PYTHON_SITELIBDIR%%/libnamebench/util_test.py %%PYTHON_SITELIBDIR%%/libnamebench/__init__.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/addr_util.py +%%PYTHON_SITELIBDIR%%/libnamebench/addr_util.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/base_ui.py %%PYTHON_SITELIBDIR%%/libnamebench/base_ui.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/benchmark.py %%PYTHON_SITELIBDIR%%/libnamebench/benchmark.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/benchmark_test.py %%PYTHON_SITELIBDIR%%/libnamebench/benchmark_test.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/better_webbrowser.py %%PYTHON_SITELIBDIR%%/libnamebench/better_webbrowser.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/charts.py %%PYTHON_SITELIBDIR%%/libnamebench/charts.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/charts_test.py %%PYTHON_SITELIBDIR%%/libnamebench/charts_test.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/cli.py %%PYTHON_SITELIBDIR%%/libnamebench/cli.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/config.py %%PYTHON_SITELIBDIR%%/libnamebench/config.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/conn_quality.py %%PYTHON_SITELIBDIR%%/libnamebench/conn_quality.pyc -%%PYTHON_SITELIBDIR%%/libnamebench/history_parser.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/data_sources.py +%%PYTHON_SITELIBDIR%%/libnamebench/data_sources.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/geoip.py +%%PYTHON_SITELIBDIR%%/libnamebench/geoip.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/health_checks.py +%%PYTHON_SITELIBDIR%%/libnamebench/health_checks.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/mocks.py %%PYTHON_SITELIBDIR%%/libnamebench/mocks.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/nameserver.py %%PYTHON_SITELIBDIR%%/libnamebench/nameserver.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/nameserver_list.py %%PYTHON_SITELIBDIR%%/libnamebench/nameserver_list.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/nameserver_test.py %%PYTHON_SITELIBDIR%%/libnamebench/nameserver_test.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/reporter.py +%%PYTHON_SITELIBDIR%%/libnamebench/reporter.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/selectors.py %%PYTHON_SITELIBDIR%%/libnamebench/selectors.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/selectors_test.py %%PYTHON_SITELIBDIR%%/libnamebench/selectors_test.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/site_connector.py +%%PYTHON_SITELIBDIR%%/libnamebench/site_connector.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/tk.py %%PYTHON_SITELIBDIR%%/libnamebench/tk.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/url_map.py +%%PYTHON_SITELIBDIR%%/libnamebench/url_map.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/util.py %%PYTHON_SITELIBDIR%%/libnamebench/util.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/util_test.py %%PYTHON_SITELIBDIR%%/libnamebench/util_test.pyc +%%PYTHON_SITELIBDIR%%/libnamebench/version.py +%%PYTHON_SITELIBDIR%%/libnamebench/version.pyc %%PYTHON_SITELIBDIR%%/namebench.py %%PYTHON_SITELIBDIR%%/namebench.pyc -%%DATADIR%%/namebench.cfg +%%DOCSDIR%%/README.txt +%%DATADIR%%/config/data_sources.cfg +%%DATADIR%%/config/hostname_reference.cfg +%%DATADIR%%/config/namebench.cfg +%%DATADIR%%/data/alexa-top-2000-domains.txt +%%DATADIR%%/data/cache-hit.txt +%%DATADIR%%/data/cache-miss.txt +%%DATADIR%%/data/cache-mix.txt %%DATADIR%%/templates/ascii.tmpl %%DATADIR%%/templates/html.tmpl +%%DATADIR%%/templates/resolv.conf.tmpl %%DATADIR%%/templates/style.css -%%DATADIR%%/data/alexa-top-10000-global.txt @dirrm %%DATADIR%%/templates @dirrm %%DATADIR%%/data +@dirrm %%DATADIR%%/config @dirrm %%DATADIR%% +@dirrm %%DOCSDIR%% @dirrm %%PYTHON_SITELIBDIR%%/libnamebench +@cwd /etc +namebench -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5
Re-sending patch so it will attach properly, including comments (to be on the safe side). Here is an updated patch that fixes having to have a wrapper script. By adding a symlink of /etc/namebench that points to /usr/local/share/namebench, the binary (namebench.py) runs without issue. Please ignore the previous patch. Thanks! This builds cleanly in Tinderbox. -jgh -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5
I'm interested in taking over maintainer-ship for this port. jhelfman@experts-exchange.com Thanks jgh -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5
Responsible Changed From-To: freebsd-ports-bugs->crees Grab
State Changed From-To: open->analyzed Taken for Tinderbox
crees 2011-08-16 09:07:11 UTC FreeBSD ports repository Modified files: dns/py-namebench Makefile distinfo pkg-plist Added files: dns/py-namebench/files patch-libnamebench-util-py Log: - Update to 1.3.1 - Pass maintainership to submitter (thank you for volunteering) - Add LICENSE - Unbreak -- fix dependencies PR: ports/158948 Submitted by: Jason Helfman <jhelfman@experts-exchange.com> Revision Changes Path 1.4 +20 -5 ports/dns/py-namebench/Makefile 1.3 +2 -2 ports/dns/py-namebench/distinfo 1.1 +15 -0 ports/dns/py-namebench/files/patch-libnamebench-util-py (new) 1.2 +45 -22 ports/dns/py-namebench/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->closed Committed, with minor changes. Thanks!