- Fix build when multimedia/libass is installed. - Unfortunately, mplayer's configure honors neither --disable-ass nor --disable-ass-internal. Therefore, we must circumvent this glitch with some port Makefile magic: 1) Allow user to decide if he wants to install libass 2) If it is already installed, override user decision to "always depend on it" 3) It libass is installed, patch mplayer Makefile accordingly 4) Then, REINPLACE with correct libass CFLAGS to fix codec-cfg.c build - Follow patches for both mplayer and mencoder. Port maintainer (riggs@rrr.de) is cc'd. Generated with FreeBSD Port Tools 0.99
Responsible Changed From-To: freebsd-ports-bugs->lioux Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of multimedia/mplayer, Please note that PR ports/159021 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159021 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Patch looks alright, please commit.
lioux 2011-07-20 02:52:22 UTC FreeBSD ports repository Modified files: multimedia/mplayer Makefile multimedia/mplayer/files patch-Makefile Log: o Fix build when multimedia/libass is already installed when one tries to build multimedia/mplayer * Add option 'ASS "Enable ASS/SSA subtitle rendering"' with default off - However, override user decision to on if multimedia/libass is already installed: mplayer does not uphold configure options disabling dependency on external port. * Do not bump PORTREVISION since nothing has really changed for users who didn't have multimedia/libass on their systems PR: ports/159021 Approved by: maintainer Revision Changes Path 1.207 +19 -0 ports/multimedia/mplayer/Makefile 1.2 +15 -3 ports/multimedia/mplayer/files/patch-Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
lioux 2011-07-20 02:52:35 UTC FreeBSD ports repository Modified files: multimedia/mencoder Makefile Log: o Fix build when multimedia/libass is already installed when one tries to build multimedia/mplayer * Add option 'ASS "Enable ASS/SSA subtitle rendering"' with default off - However, override user decision to on if multimedia/libass is already installed: mplayer does not uphold configure options disabling dependency on external port. * Do not bump PORTREVISION since nothing has really changed for users who didn't have multimedia/libass on their systems PR: ports/159021 Approved by: maintainer Revision Changes Path 1.28 +19 -0 ports/multimedia/mencoder/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!