- Update to 1.1.2 - Use gnomehack - Pet portlint Port maintainer (fbsd@opal.com) is cc'd. Generated with FreeBSD Port Tools 0.99
Responsible Changed From-To: freebsd-ports-bugs->sunpoet Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of sysutils/xorriso, Please note that PR ports/159098 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159098 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
State Changed From-To: feedback->open From misfiled PR ports/159107: Date: Fri, 22 Jul 2011 11:03:58 +0200
On Fri, Jul 22, 2011 at 11:03:58AM +0200, J.R. Oldroyd wrote: > I am OK with this upgrade patch, except that I would change > RUN_DEPENDS= ${BUILD_DEPENDS} > instead of repeating the same libraries. Hi, We don't recommend this way. It'll add some superfluous runtime dependencies, e.g. gmake in this case. The other solution is to set RUN_DEPENDS:=${BUILD_DEPENDS}. > Also, I am CC'in Alexey here because he had said he'd be interested > in taking over maintainership of this port, so perhaps that change > can also be made at the same time. > > -jr Ok, I'll wait for Alexay's response. Thanks. Regards, -- Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org> 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
On Fri, Jul 22, 2011 at 08:00:54PM +0800, Sunpoet Po-Chuan Hsieh wrote: > On Fri, Jul 22, 2011 at 11:03:58AM +0200, J.R. Oldroyd wrote: > > I am OK with this upgrade patch, except that I would change > > RUN_DEPENDS= ${BUILD_DEPENDS} > > instead of repeating the same libraries. > > Hi, > > We don't recommend this way. It'll add some superfluous runtime > dependencies, e.g. gmake in this case. > > The other solution is to set RUN_DEPENDS:=${BUILD_DEPENDS}. > +10! I already have met such constructions and yes, they really add such build tools like gmake or intltool to RUN_DEPENDS, which is wrong. I'd vote to leave it as is, RUN_DEPENDS duplicating BUILD_DEPENDS. > > Also, I am CC'in Alexey here because he had said he'd be interested > > in taking over maintainership of this port, so perhaps that change > > can also be made at the same time. > > > > -jr > > Ok, I'll wait for Alexay's response. > Thanks. > Yes, you can assign me as a maintainer too. Small question about this port too: I have successfully installed (and somewhat run-time tested) it with the following lines commented out: #CFLAGS+= -I${LOCALBASE}/include #CONFIGURE_ENV= LDFLAGS="${LDFLAGS}" GNU_CONFIGURE= yes #LDFLAGS+= -lcam -L${LOCALBASE}/lib -liconv Are they really needed? Thanks, Alexey.
Thanks for agreeing to take it over, Alexey. Got the message re not using the RUN=BUILD short-hand. I'll check my other ports for that when I am doing future updates. As for the (no-longer?) needed libs and paths, it was almost three years ago since I did this port, and I can't remember why I needed those lines. But I generally do start with a blank Makefile and only add things that I find are needed. So it could be that the code has changed now. I'm kinda surprised that it no longer needs the -lcam lib now, though. You can contact the developer, Thomas Schmitt scdbackup at gmx.net who is very helpful and keen to have it work as simply as possible on FreeBSD. -jr
On Mon, Jul 25, 2011 at 06:15:48PM +0200, J.R. Oldroyd wrote: > Thanks for agreeing to take it over, Alexey. > > Got the message re not using the RUN=BUILD short-hand. I'll check > my other ports for that when I am doing future updates. > > As for the (no-longer?) needed libs and paths, it was almost three > years ago since I did this port, and I can't remember why I needed > those lines. But I generally do start with a blank Makefile and > only add things that I find are needed. So it could be that the > code has changed now. I'm kinda surprised that it no longer needs > the -lcam lib now, though. > I suppose it picks it through libburn.so.4? Or it does not call any function in libcam directly? > You can contact the developer, Thomas Schmitt scdbackup at gmx.net > who is very helpful and keen to have it work as simply as possible > on FreeBSD. > Yes, I'm planning to do so, at least to change linking of threaded programs on FreeBSD via -pthread and not -lpthread. Thanks for the follow-up! Alexey.
State Changed From-To: open->closed Committed. Thanks!
sunpoet 2011-07-28 06:45:27 UTC FreeBSD ports repository Modified files: sysutils/xorriso Makefile distinfo pkg-plist Log: - Update to 1.1.2 - Use gnomehack - Pet portlint - Pass maintainership to new volunteer (maintainer of devel/libburn and devel/libisofs) Changes: http://libburnia-project.org/browser/libisoburn/tags/1.1.2/ChangeLog PR: ports/159098 Submitted by: sunpoet (myself) Approved by: J.R. Oldroyd <fbsd@opal.com> (maintainer) Revision Changes Path 1.5 +12 -17 ports/sysutils/xorriso/Makefile 1.6 +2 -2 ports/sysutils/xorriso/distinfo 1.4 +1 -0 ports/sysutils/xorriso/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"