Bug 159173 - cad/spice: more CLANG fixes
Summary: cad/spice: more CLANG fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 04:20 UTC by Pedro F. Giffuni
Modified: 2011-07-28 23:22 UTC (History)
0 users

See Also:

Attachments
file.diff (2.52 KB, patch)
2011-07-25 04:20 UTC, Pedro F. Giffuni 		no flags Details | Diff
patch-spice.txt (4.02 KB, patch)
2011-07-27 05:27 UTC, Pedro F. Giffuni 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni 2011-07-25 04:20:10 UTC 
Second round of clang fixes from latest pointyhat build:
- add "void" as the return type for some functions
- no functional change (still builds with gcc)

Fix: Patch attached.

Patch attached with submission follows:
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2011-07-26 23:34:40 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->zi

I'll take it.
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2011-07-26 23:36:26 UTC 
Class Changed
From-To: change-request->update

Fix class
Comment 3 Pedro F. Giffuni 2011-07-27 05:27:35 UTC 
Thank you for the feedback Ryan!

Here is an updated patch.

cheers,

Pedro.
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-07-28 22:58:23 UTC 
zi          2011-07-28 21:58:16 UTC

  FreeBSD ports repository

  Modified files:
    cad/spice            Makefile pkg-plist 
    cad/spice/files      patch-src_lib_fte_device_c 
                         patch-src_lib_fte_x11_c 
  Added files:
    cad/spice/files      patch-src_lib_mfb_mfbgnc_c 
  Log:
  Fix build under clang [1]
  Add LICENSE
  Fix usage of PORTDOCS in plist, no bump required
  
  PR:             ports/159173
  Submitted by:   Pedro Giffuni <giffunip@tutopia.com> [1]
  Approved by:    tabthorpe (mentor)
  
  Revision  Changes    Path
  1.41      +3 -1      ports/cad/spice/Makefile
  1.3       +21 -4     ports/cad/spice/files/patch-src_lib_fte_device_c
  1.3       +54 -8     ports/cad/spice/files/patch-src_lib_fte_x11_c
  1.1       +10 -0     ports/cad/spice/files/patch-src_lib_mfb_mfbgnc_c (new)
  1.10      +21 -21    ports/cad/spice/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2011-07-28 23:22:14 UTC 
State Changed
From-To: open->closed

Committed. Thanks!