Bug 159829 - [maintainer] upgrade distinfo for net/openafs
Summary: [maintainer] upgrade distinfo for net/openafs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-17 04:20 UTC by Ben Kaduk
Modified: 2011-08-20 16:50 UTC (History)
0 users

See Also:


Attachments
file.diff (1.04 KB, patch)
2011-08-17 04:20 UTC, Ben Kaduk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kaduk 2011-08-17 04:20:09 UTC
Upstream's Grand.Central.Org CellServDB registry of AFS cells has released an update.  Since this packaging always pulls the newest CellServDB, users will get a checksum mismatch without a distinfo update.

Fix: Patch attached with submission follows:
How-To-Repeat: Attempt to build net/openafs without already having a copy of the CellServDB distfile
Comment 1 Chris Rees freebsd_committer freebsd_triage 2011-08-17 07:37:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 2 Chris Rees freebsd_committer freebsd_triage 2011-08-17 08:06:53 UTC
State Changed
From-To: open->feedback

Hi Ben, please would you ask upstream for an explanation as to why 
they've changed the distfile without a version bump, and if possible get 
them to do releases properly?
Comment 3 Chris Rees 2011-08-17 08:11:22 UTC
Oops, got sloppy there and didn't read which distfile has changed.

In all honesty, the database should really be installed by a script 
installed by the port, called something like 
${PREFIX}/libexec/openafs.updatedb... Perhaps it could be run from cron.

Unfortunately it's not really acceptable for a distfile to be silently 
changing on the server and us to just keep bumping the SHA256.

Please would you consider such a script / ask upstream if they have one?

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 4 Ben Kaduk 2011-08-17 18:32:06 UTC
On Wed, 17 Aug 2011, Chris Rees wrote:

> Oops, got sloppy there and didn't read which distfile has changed.
>
> In all honesty, the database should really be installed by a script installed 
> by the port, called something like ${PREFIX}/libexec/openafs.updatedb... 
> Perhaps it could be run from cron.
>
> Unfortunately it's not really acceptable for a distfile to be silently 
> changing on the server and us to just keep bumping the SHA256.
>
> Please would you consider such a script / ask upstream if they have one?

Hi Chris,

Thanks for taking a look.
Things are perhaps a bit more complicated than they might seem, in that 
there are really two "upstream"s involved, here.  Grand.Central.Org is a 
sort of clearinghouse for most things AFS, and acts as a registry for 
public AFS cells; publishing the CellServDB which is that registry is one 
of the services it provides.  OpenAFS is a nominally separate entity (but 
run by mostly the same people), which is a particular implementation of 
the afs3 standard -- there are other implementations as well.

GCO publishes a "current" CellServDB, as well as keeping around the 
current and older ones with date suffices:
athena% ls -ld /afs/grand.central.org/service/csdb/CellServDB*
-rw-r--r--   1 daemon   100        36836 Aug 14 13:57 
/afs/grand.central.org/service/csdb/CellServDB
-rw-r--r--   1 daemon   100        30175 Jun  7  2007 
/afs/grand.central.org/service/csdb/CellServDB.2005-10-15
-rw-r--r--   1 daemon   100        31825 Jun  7  2007 
/afs/grand.central.org/service/csdb/CellServDB.2007-03-09
-rw-r--r--   1 daemon   100        32393 Jul  5  2007 
/afs/grand.central.org/service/csdb/CellServDB.2007-07-05
-rw-r--r--   1 daemon   100        33416 Oct 25  2007 
/afs/grand.central.org/service/csdb/CellServDB.2007-10-25
-rw-r--r--   1 daemon   100        34615 Apr 23  2008 
/afs/grand.central.org/service/csdb/CellServDB.2008-04-23
-rw-r--r--   1 daemon   100        36030 Nov  7  2008 
/afs/grand.central.org/service/csdb/CellServDB.2008-11-07
-rw-r--r--   1 75338    staff      36096 Jul 21  2009 
/afs/grand.central.org/service/csdb/CellServDB.2009-06-29
-rw-r--r--   1 daemon   100        36225 Feb 28  2010 
/afs/grand.central.org/service/csdb/CellServDB.2010-02-28
-rw-r--r--   1 daemon   1000       36891 Dec 13  2010 
/afs/grand.central.org/service/csdb/CellServDB.2010-12-13
-rw-r--r--   1 daemon   1000       36836 Aug 14 13:57 
/afs/grand.central.org/service/csdb/CellServDB.2011-08-14

As you can see, it updates roughly once or twice a year, so I hadn't given 
it much thought when I first created the packaging for net/openafs.
I'm not really keen on the idea of an automatic upgrading script 
(particularly without sanity-checking of what has changed), so it sounds 
like I should change the packaging to always fetch a timestamped copy of 
the CellServDB and install it without the suffix.

-Ben
Comment 5 Chris Rees freebsd_committer freebsd_triage 2011-08-19 11:28:14 UTC
Hey Ben,

Take a look at [1], it grabs the versioned db and appends the version
to PORTVERSION. If it's OK let me know and I'll commit it.

[1] http://www.bayofrum.net/~crees/patches/openafs-versioneddb.diff

Chris
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-08-19 18:46:37 UTC
crees       2011-08-19 17:46:28 UTC

  FreeBSD ports repository

  Modified files:
    net/openafs          Makefile distinfo 
  Log:
  Update database version, and ensure they're versioned in future.
  
  PR:             ports/159829
  Submitted by:   Ben Kaduk <kaduk@mit.edu> (maintainer)
  
  Revision  Changes    Path
  1.6       +13 -10    ports/net/openafs/Makefile
  1.4       +2 -2      ports/net/openafs/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Chris Rees freebsd_committer freebsd_triage 2011-08-19 18:46:42 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 8 dfilter service freebsd_committer freebsd_triage 2011-08-20 16:44:11 UTC
crees       2011-08-20 15:43:54 UTC

  FreeBSD ports repository

  Modified files:
    net/openafs          Makefile 
  Log:
  Apparently 1.6.0.p7.d20110814 < 1.6.0.p7, so cut the 'd' to keep numerical order
  
  PR:             ports/159829
  drosomail:      crees
  
  Revision  Changes    Path
  1.7       +1 -1      ports/net/openafs/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"