Bug 159952 - [PATCH] irc/znc: update to 0.200
Summary: [PATCH] irc/znc: update to 0.200
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-21 05:00 UTC by Jase Thew
Modified: 2011-10-23 17:00 UTC (History)
1 user (show)

See Also:

Attachments
znc-0.200.patch (13.78 KB, patch)
2011-08-21 05:00 UTC, Jase Thew 		no flags Details | Diff
znc-0.202.patch (13.79 KB, patch)
2011-09-22 10:11 UTC, Jase Thew 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jase Thew 2011-08-21 05:00:24 UTC 
- Update to 0.200
- Add LICENSE
- Change IPv6 option default to On
- Fix typo in WITH_TCLALLOWALL/WITHOUT_TCL IGNORE message
- Fix CONFIGURE_ARGS for PYTHON option
- Fix pkg-plist to use dirrm instead of dirrmtry where necessary
- Add check for EXTRA option to SASL option (required to build)

Removed file(s):
- files/patch-modules-Makefile_in

Port maintainer (miwi@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-21 05:00:38 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2011-08-26 07:44:39 UTC 
State Changed
From-To: open->feedback

why u remove @dirrmtry ?
Comment 3 Jase Thew 2011-08-26 20:26:00 UTC 
On 26/08/2011 07:44, miwi@FreeBSD.org wrote:
> Synopsis: [PATCH] irc/znc: update to 0.200
>
> State-Changed-From-To: open->feedback
> State-Changed-By: miwi
> State-Changed-When: Fri Aug 26 06:44:39 UTC 2011
> State-Changed-Why:
> why u remove @dirrmtry ?
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=159952

Isn't it the correct thing to do?

Those directories shouldn't contain any files other than what is taken 
care of by the port, so deletion failures by dirrm shouldn't occur and 
as a result needn't be masked with dirrmtry.

It's my understanding that dirrmtry is to be used when there is the 
likelyhood of files/directories being created/installed into the 
directories listed in a port's pkg-plist by some external mechanism 
(either user created files or some other port creating files there)

In this case, there should be no occurrences of this.

Please let me know if this understanding is incorrect.

Regards,

Jase.
Comment 4 Jase Thew 2011-09-22 10:11:17 UTC 
Please find attached an updated patch to update irc/znc to v0.202.

- Update to 0.202
- Add LICENSE
- Change IPv6 option default to On
- Fix typo in WITH_TCLALLOWALL/WITHOUT_TCL IGNORE message
- Fix CONFIGURE_ARGS for PYTHON option
- Add check for EXTRA option to SASL option (required to build)

Removed file(s):
- files/patch-modules-Makefile_in
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-10-23 16:52:50 UTC 
miwi        2011-10-23 15:52:36 UTC

  FreeBSD ports repository

  Modified files:
    irc/znc              Makefile distinfo pkg-plist 
  Removed files:
    irc/znc/files        patch-modules-Makefile_in 
  Log:
  - Update to 0.202
  - Add LICENSE
  - Change IPv6 option default to On
  - Fix typo in WITH_TCLALLOWALL/WITHOUT_TCL IGNORE message
  - Fix CONFIGURE_ARGS for PYTHON option
  - Add check for EXTRA option to SASL option (required to build)
  
  PR:             159952
  Submitted by:   Jase Thew <freebsd@beardz.net>
  
  Revision  Changes    Path
  1.23      +10 -5     ports/irc/znc/Makefile
  1.19      +2 -2      ports/irc/znc/distinfo
  1.2       +0 -11     ports/irc/znc/files/patch-modules-Makefile_in (dead)
  1.18      +112 -93   ports/irc/znc/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2011-10-23 16:53:12 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!