Bug 160012 - [maintainer-update] [patch] net-p2p/lopster portlint cleanup
Summary: [maintainer-update] [patch] net-p2p/lopster portlint cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 01:20 UTC by Conrad J. Sabatier
Modified: 2011-09-07 20:50 UTC (History)
0 users

See Also:

Attachments
lopster-patch (1.44 KB, text/plain)
2011-08-23 01:20 UTC, Conrad J. Sabatier 		no flags Details
lopster.diff (4.88 KB, patch)
2011-08-31 14:53 UTC, Conrad J. Sabatier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad J. Sabatier 2011-08-23 01:20:09 UTC 
	Update net-p2p/lopster to conform to portlint's recommendations.

	In addition:

	o Add explicit dependency handling for flac
	o Modify pre-everything output to be a little clearer for less
	  experienced ports users

Fix: Patch below.
How-To-Repeat: 	N/A
Comment 1 Conrad J. Sabatier 2011-08-31 14:53:13 UTC 
I've further revised this port to incorporate the following changes:

1) Move CPPFLAGS out of the CONFIGURE_ENV variable, as per portlint

1) Convert all of the "ad hoc" WITH* variable handling to use the
   standard OPTIONS scheme instead, and ensure that LIB_DEPENDS are
   all declared.

2) Remove the post-patch: target (which did a few sed substitutions)
   and add patch files in its place.

3) Rename the non-standard patch file patch-src::global.c to
   patch-src-global.c to conform to conventions for patch filenames.

I believe this should be the final set of changes needed to bring this
port into full compliance with port standards.

Conrad J. Sabatier

[lopster.diff attached]
Comment 2 Chris Rees freebsd_committer freebsd_triage 2011-09-05 19:45:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 3 Chris Rees 2011-09-05 20:01:14 UTC 
Hi Conrad,

I've put all your changes in except the sed to patchfile change--
that'd bloat the port for no gain.

However, these style changes are hugely appreciated and make the Ports
Tree a more friendly and less dangerous place to play, so thank you.

I'm testing it now.

Chris

--=20
Chris Rees =A0 =A0 =A0 =A0 =A0| FreeBSD Developer
crees@FreeBSD.org =A0 | http://people.freebsd.org/~crees
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-09-07 20:44:41 UTC 
crees       2011-09-07 19:44:28 UTC

  FreeBSD ports repository

  Modified files:
    net-p2p/lopster      Makefile 
  Added files:
    net-p2p/lopster/files patch-src-global.c 
  Removed files:
    net-p2p/lopster/files patch-src::global.c 
  Log:
  Cleanup, and stop auto-detecting OGG-- now an option.
  
  PR:             ports/160012
  Submitted by:   Conrad J. Sabatier <conrads@cox.net>
  
  Revision  Changes    Path
  1.45      +21 -17    ports/net-p2p/lopster/Makefile
  1.1       +16 -0     ports/net-p2p/lopster/files/patch-src-global.c (new)
  1.6       +0 -11     ports/net-p2p/lopster/files/patch-src::global.c (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Chris Rees freebsd_committer freebsd_triage 2011-09-07 20:45:01 UTC 
State Changed
From-To: open->closed

Committed. Thanks!