Bug 160049 - [PATCH] emulators/wahcade: eliminate py-elementtree dependency
Summary: [PATCH] emulators/wahcade: eliminate py-elementtree dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 10:30 UTC by R.Mahmatkhanov
Modified: 2011-09-07 21:01 UTC (History)
0 users

See Also:

Attachments
file.diff (626 bytes, patch)
2011-08-24 10:30 UTC, R.Mahmatkhanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-08-24 10:30:08 UTC 
This port have dependency on devel/py-elementtree. At the same time USE_PYTHON= 2.5+ is defined. elementtree is a part of python since 2.5, so this dependency isn't needed. Removing it.
See: http://docs.python.org/library/xml.etree.elementtree.html

Bump portrevision cause of dependencies list change.

Fix: Patch attached with submission follows:
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2011-09-01 14:34:45 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I'll take it.
Comment 2 R.Mahmatkhanov 2011-09-03 20:24:55 UTC 
I forgot to add that in the code the use this pattern:

"""
try:
     import xml.etree.ElementTree as ET # in python >=2.5
except ImportError:
     try:
         import cElementTree as ET # effbot's C module
     except ImportError:
         try:
             import elementtree.ElementTree as ET # effbot's pure Python 
module
         except ImportError:
             try:
                 import lxml.etree as ET # ElementTree API using libxml2
             except ImportError:
                 import warnings
                 warning.warn("could not import ElementTree "
                              "(http://effbot.org/zone/element-index.htm)")
"""

So nothing will be broken with dropping of this dep.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-09-07 20:51:00 UTC 
eadler      2011-09-07 19:50:46 UTC

  FreeBSD ports repository

  Modified files:
    deskutils/griffith   Makefile 
    emulators/wahcade    Makefile 
    security/zenmap      Makefile 
  Log:
  - emulators/wahcade: eliminate py-elementtree dependency [0]
  - security/zenmap: eliminate py-pysqlite2x dependency [1]
  - deskutils/griffith: eliminate py-pysqlite2x dependency [2]
  
  PR:             ports/160049 [0], ports/160071 [1], ports/160161 [2]
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru> [0,1,2]
  Approved by:    bapt (mentor)
  
  Revision  Changes    Path
  1.20      +9 -9      ports/deskutils/griffith/Makefile
  1.25      +1 -2      ports/emulators/wahcade/Makefile
  1.53      +5 -5      ports/security/zenmap/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2011-09-07 21:01:58 UTC 
State Changed
From-To: open->closed

Committed. Thanks!