Bug 160051 - [PATCH] net/py-s3cmd: eliminate py-elementtree dependency
Summary: [PATCH] net/py-s3cmd: eliminate py-elementtree dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cheng-Lung Sung
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 11:00 UTC by R.Mahmatkhanov
Modified: 2011-09-28 02:22 UTC (History)
0 users

See Also:


Attachments
file.diff (1.06 KB, patch)
2011-08-24 11:00 UTC, R.Mahmatkhanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-08-24 11:00:22 UTC
- bump USE_PYTHON to 2.5+ since python24 is no more supported upstream (actually python25 too, but the point is to not depend on 24)
- remove dependency on elementtree, since elementtree is a part of python since 2.5, so this dependency isn't needed (please see http://docs.python.org/library/xml.etree.elementtree.html)
- while here add license
- use dirrm instead of dirrmtry while dealing with package directory in PYTHON_SITELIBDIR in pkg-plist - i've checked it both with and without NOPORTDOCS=yes and all is work as expected.
- bump PORTREVISION cause of dependencies list change

tinderbuild log (8.2):
http://happy-nation.by.ru/ports/tb/8.2/py27-s3cmd-1.0.1_1.log

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-24 11:00:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->clsung

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 R.Mahmatkhanov 2011-09-03 20:28:15 UTC
I forgot to add that in the code the use this pattern:

"""
try:
         import xml.etree.ElementTree as ET
         print "Using xml.etree.ElementTree for XML processing"
except ImportError, e:
         sys.stderr.write(str(e) + "\n")
         try:
                 import elementtree.ElementTree as ET
                 print "Using elementtree.ElementTree for XML processing"
         except ImportError, e:
                 sys.stderr.write(str(e) + "\n")
                 sys.stderr.write("Please install ElementTree module 
from\n")
 
sys.stderr.write("http://effbot.org/zone/element-index.htm\n")
                 sys.exit(1)
"""

So nothing will be broken with dropping of this dep.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.
Comment 3 Cheng-Lung Sung freebsd_committer freebsd_triage 2011-09-28 02:21:36 UTC
State Changed
From-To: open->closed

Updated. Thanks.