- since this port requires python2.5+ (with USE_PYTHON) switch to databases/py-sqlite3 instead of databases/py-pysqlite2x that is for python24 - bump portrevision because of this deps changes I checked the code and they use this pattern when dealing with sqlite: """ try: from pysqlite2 import dbapi2 as sqlite3 except ImportError: import sqlite3 """ So nothing will be broken with sqlite3. Fix: Patch attached with submission follows:
Maintainer of multimedia/pyjama, Please note that PR ports/160065 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160065 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
On Wednesday 24 August 2011 16:10:16 you wrote: > Maintainer of multimedia/pyjama, > > Please note that PR ports/160065 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160065 > > Thanks! Please apply the attached patch, which in addition to the original also adds needed dependency on gstreamer-plugins-gnomevfs. --- Makefile.orig 2011-02-25 01:47:49.000000000 +0100 +++ Makefile 2011-08-24 22:20:29.000000000 +0200 @@ -6,7 +6,7 @@ PORTNAME= pyjama PORTVERSION= 0.3.0.1 -PORTREVISION= 5 +PORTREVISION= 6 CATEGORIES= multimedia python MASTER_SITES= http://launchpadlibrarian.net/26637583/ DISTNAME= pyjama-0.3.0.1_all @@ -14,7 +14,7 @@ MAINTAINER= ktullavik@gmail.com COMMENT= Frontend to the Jamendo music network -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pysqlite>=2.3:${PORTSDIR}/databases/py-pysqlite23 \ +RUN_DEPENDS= ${PYTHON_SITELIBDIR}/_sqlite3.so:${PORTSDIR}/databases/py-sqlite3 \ ${PYTHON_PKGNAMEPREFIX}lxml>=2.2:${PORTSDIR}/devel/py-lxml \ ${PYTHON_PKGNAMEPREFIX}simplejson>=2.0:${PORTSDIR}/devel/py-simplejson \ ${PYTHON_PKGNAMEPREFIX}gstreamer>=0.10:${PORTSDIR}/multimedia/py-gstreamer @@ -22,7 +22,7 @@ NO_BUILD= yes USE_PYTHON= 2.5+ -USE_GSTREAMER= core good bad +USE_GSTREAMER= core good bad gnomevfs USE_GNOME= pygtk2 USE_GETTEXT= yes
State Changed From-To: feedback->open Maintainer replied with an updated patch.
Responsible Changed From-To: freebsd-ports-bugs->eadler I'll take it.
eadler 2011-08-31 17:52:32 UTC FreeBSD ports repository Modified files: games/anki Makefile.inc multimedia/pyjama Makefile Log: - eliminate py-pysqlite2x dependency from games/anki [0] - eliminate py-pysqlite2x dependency from multimedia/pyjama [1] - add gstreamer-plugins-gnomevfs as a dep to multimedias/pyjama [2] PR: ports/160055 [0], ports/160065 [1,2] Submitted by: Ruslan Mahmatkhanov <cvs-src@yandex.ru> [0,1], Kjell Tore Ullavik <ktullavik@gmail.com> (maintainer) [2] Approved by: bapt (mentor), Kjell Tore Ullavik <ktullavik@gmail.com> (maintainer) Revision Changes Path 1.12 +3 -3 ports/games/anki/Makefile.inc 1.7 +3 -3 ports/multimedia/pyjama/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!