Bug 160174 - [PATCH] japanese/jcode.pl Fix defined(%hash) is deprecated
Summary: [PATCH] japanese/jcode.pl Fix defined(%hash) is deprecated
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: TAKATSU Tomonari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 08:50 UTC by takefu
Modified: 2013-03-17 04:53 UTC (History)
0 users

See Also:

Attachments
ja-jcode.pl.patch (1.93 KB, patch)
2011-08-25 08:50 UTC, takefu 		no flags Details | Diff
ja-jcode.pl-2.13_1.patch (1.98 KB, patch)
2011-10-01 13:51 UTC, TAKATSU Tomonari 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2011-08-25 08:50:09 UTC 
  lang/perl5.12 or lang/perl5.14 problems occur in combination.
  z2h_euc z2h_sjis and was out of the way to improve call and message.

# fined(%hash) is deprecated at /usr/local/lib/perl5/site_perl/5.12.1/jcode.pl line 684.
# 	(Maybe you should just omit the defined()?)
# defined(%hash) is deprecated at /usr/local/lib/perl5/site_perl/5.12.1/jcode.pl line 693.
# 	(Maybe you should just omit the defined()?)

  see PR#149544

How-To-Repeat: #!/usr/local/bin/perl
require "jcode.pl";
$data = "";
jcode::z2h_sjis(\$data);
exit;
Comment 1 TAKATSU Tomonari freebsd_committer freebsd_triage 2011-10-01 12:49:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->tota

I'll take it.
Comment 2 TAKATSU Tomonari freebsd_committer freebsd_triage 2011-10-01 13:51:14 UTC 
Hi, Takefu-san

I have modified your patch.

- Remove CONFLICTS because ja-p5-jcode.pl was removed from ports tree [1]
- Rename patch-aa to patch-jcode.pl [2]

Please confirm it.

[1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/japanese/p5-jcode.pl/?hideattic=0#dirlist
[2] see 4.4 Patching FreeBSD Porter's Handbook
     http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html

Thanks,

-- 
TAKATSU Tomonari
Comment 3 takefu 2011-10-03 01:35:57 UTC 
$B$?$1$U!wBg:eK-Cf$G$9!#(B

It consented to the full text.
Rework, thank you.

TAKATSU Tomonari $B$5$s$O=q$-$^$7$?(B (2011/10/01 21:51):
> Hi, Takefu-san
> 
> I have modified your patch.
> 
> - Remove CONFLICTS because ja-p5-jcode.pl was removed from ports tree [1]
> - Rename patch-aa to patch-jcode.pl [2]
> 
> Please confirm it.
> 
> [1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/japanese/p5-jcode.pl/?hideattic=0#dirlist
> [2] see 4.4 Patching FreeBSD Porter's Handbook
>      http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html
> 
> Thanks,
> 


--
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-10-03 22:48:50 UTC 
tota        2011-10-03 21:48:36 UTC

  FreeBSD ports repository

  Modified files:
    japanese/jcode.pl    Makefile 
  Added files:
    japanese/jcode.pl/files patch-jcode.pl 
  Log:
  - Add a patch to fix deprecated defined(%hash) issue
  
  PR:             ports/160174
  Submitted by:   Takefu <takefu_AT_airport_DOT_fm>
  
  Revision  Changes    Path
  1.13      +7 -8      ports/japanese/jcode.pl/Makefile
  1.1       +20 -0     ports/japanese/jcode.pl/files/patch-jcode.pl (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 TAKATSU Tomonari freebsd_committer freebsd_triage 2011-10-03 22:50:06 UTC 
State Changed
From-To: open->closed

Committed. Thanks!