Bug 160233 - [patch][update] devel/pinba_engine Update to new revision & FIX: build with MYSQL >= 51
Summary: [patch][update] devel/pinba_engine Update to new revision & FIX: build with M...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-27 16:20 UTC by komarov
Modified: 2012-01-06 19:50 UTC (History)
0 users

See Also:


Attachments
file.diff (4.13 KB, patch)
2011-08-27 16:20 UTC, komarov
no flags Details | Diff
pr_160233_devel_pinba_engine.txt (3.72 KB, text/plain)
2012-01-05 13:08 UTC, Michael Scheidell
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description komarov 2011-08-27 16:20:11 UTC
Update to new revision 
FIX: build with MYSQL >= 51

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-27 16:20:24 UTC
Maintainer of devel/pinba_engine,

Please note that PR ports/160233 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160233

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-27 16:20:26 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2011-12-02 01:08:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it, maintainer timeout
Comment 4 Michael Scheidell freebsd_committer freebsd_triage 2011-12-02 01:27:42 UTC
komarov:

could you clarify something for me? (there are a LOT of portlint errors 
here)

why do you need mysql source code to compile this?
not just /usr/local/include/mysql/* which is installed with mysql client?

would it be sufficient to just make this depend on mysql version 51+ and 
let the ports system <bsd*.mk> files handle the tricky part?

would you be willing to try a modified patch?

-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
 >*| *SECNAP Network Security Corporation

    * Best Mobile Solutions Product of 2011
    * Best Intrusion Prevention Product
    * Hot Company Finalist 2011
    * Best Email Security Product
    * Certified SNORT Integrator
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2011-12-02 20:31:44 UTC
State Changed
From-To: feedback->open

Back to the pool. 
Isn't the latest, and will build differently for mysql 5.1 and 5.5 


Comment 6 Michael Scheidell freebsd_committer freebsd_triage 2011-12-02 20:31:44 UTC
Responsible Changed
From-To: scheidell->freebsd-ports-bugs

Back to the pool. 
Isn't the latest, and will build differently for mysql 5.1 and 5.5
Comment 7 Michael Scheidell freebsd_committer freebsd_triage 2012-01-05 12:35:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

Taking it back again,
Comment 8 Michael Scheidell 2012-01-05 13:08:28 UTC
Ok, here is the patches I am testing with.  just moved some things around to keep portlint -C happy.
raven428@gmail.com:  Are you still activly maintaining this port? or would you like to have someone else do it for you?

-- 
Michael Scheidell, CTO
SECNAP Network Security Corporation
(561) 999-5000 scheidell@secnap.net
http://www.secnap.com/

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.spammertrap.com/
______________________________________________________________________  
  
Comment 9 dfilter service freebsd_committer freebsd_triage 2012-01-06 19:45:09 UTC
scheidell    2012-01-06 19:44:58 UTC

  FreeBSD ports repository

  Modified files:
    devel/pinba_engine   Makefile distinfo 
    devel/pinba_engine/files patch-src__ha_pinba.cc 
  Log:
  - Update to new git revision & FIX: build with MYSQL >= 51
  - Note to cluster/tinderbox builders:  the 'filesystem touched' seems to be a tinderbox error. This looks like it builds ok.
  - Tried on FreeBSD 7.4 and 8.2, i386, mysql 5.1 and mysql 5.5
  
  PR:             ports/160233
  Approved by:    gabor(mentor)
  
  Revision  Changes    Path
  1.3       +18 -7     ports/devel/pinba_engine/Makefile
  1.3       +2 -2      ports/devel/pinba_engine/distinfo
  1.2       +31 -3     ports/devel/pinba_engine/files/patch-src__ha_pinba.cc
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Michael Scheidell freebsd_committer freebsd_triage 2012-01-06 19:45:16 UTC
State Changed
From-To: open->closed

Committed, Thanks.