Bug 160242 - audio/murmur installs directories with incorrect owner
Summary: audio/murmur installs directories with incorrect owner
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-27 21:40 UTC by Luke Dean
Modified: 2011-10-21 16:10 UTC (History)
0 users

See Also:


Attachments
file.diff (529 bytes, patch)
2011-08-27 21:40 UTC, Luke Dean
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Dean 2011-08-27 21:40:09 UTC
The audio/murmur port creates the "murmur" user and runs "murmurd" as this user.  The pkg-install script creates the log, pid, and database directories and assigns ownership to the person running the installation, who may not be "murmur".  murmurd will be unable to access its log, pid, or database in this situation.

Fix: One possible solution is to hardcode the user "murmur" into pkg-install instead of using ${USER} from the environment.  A better solution would use the USERS variable from the Makefile, but I don't know how to do that.

Patch attached with submission follows:
How-To-Repeat: Perform a clean installation from ports.  i.e.
su
cd /usr/ports/audio/murmur
make install

You will find that /var/log/murmur, /var/run/murmur, and /var/db/murmur have been created and are owned by ${USER} from your shell environment - you, not murmur.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-27 21:40:17 UTC
Maintainer of audio/murmur,

Please note that PR ports/160242 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160242

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-27 21:40:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2011-10-20 22:46:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 4 Ayumi M 2011-10-21 00:08:26 UTC
i approve this patch. Thanks!

2011/8/28 Edwin Groothuis <edwin@freebsd.org>:
> Maintainer of audio/murmur,
>
> Please note that PR ports/160242 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
> =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/160242
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>



--=20
Ayumi Mitsui http://ayu.commun.jp/ http://twitter.com/ayunyan
PGP: EE97 796C 77F6 CFC9 1FBC=A0 C56A 318B F019 E605 D988
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-10-21 16:01:26 UTC
pawel       2011-10-21 15:01:17 UTC

  FreeBSD ports repository

  Modified files:
    audio/murmur         pkg-install 
  Log:
  Install port specific directories with correct ownership
  
  PR:             ports/160242
  Submitted by:   Luke Dean <luked@pobox.com>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.4       +2 -2      ports/audio/murmur/pkg-install
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Pawel Pekala freebsd_committer freebsd_triage 2011-10-21 16:02:04 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!