Bug 160288 - [PATCH] security/pwman3: eliminate py-pysqlite2x dependency
Summary: [PATCH] security/pwman3: eliminate py-pysqlite2x dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 18:30 UTC by R.Mahmatkhanov
Modified: 2011-09-23 00:11 UTC (History)
0 users

See Also:


Attachments
file.diff (3.48 KB, patch)
2011-08-29 18:30 UTC, R.Mahmatkhanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-08-29 18:30:12 UTC
pwman3 is requires python 2.5+ (via USE_PYTHON) but it actually uses deprecated python24 API for accessing sqlite databases and when dealing with celementtree.
So i added a couple of simple patches that make it work with sqlite3 and xml.etree.cElementTree. 

And all is working fine on python27 with this patches: 
"""
[rm@smeshariki3 ~]> pwman3
Please enter your new password:
Please enter your new password again:
Pwman3 0.0.6 (c) Ivan Kelly <pwman@bleurgh.com>
pwman> help

Documented commands (type help <topic>):
========================================
EOF    delete  exit    filter  help    list  new     print  save  tags
clear  edit    export  forget  import  ls    passwd  rm     set 

pwman> help new
Usage: new
Creates a new node.
pwman> new
Username: popo
Password (Blank to generate): 
 Password length (default 7): 7
New password: YImvIoR
Url:      
Notes:    
Tags:     
Password ID: 1
pwman> list
Current tags:  None
    1. popo@                                              
pwman> ls
Current tags:  None
    1. popo@                                              
pwman> passwd
Please enter your current password:
Please enter your new password:
Please enter your new password again:
"""

This is the last consumer of databases/py-pysqlite23 and now it doesn't need python24 too.

- while i'm here, fix whitespace issues in pkg-descr
- bump portrevision

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-29 18:30:21 UTC
Maintainer of security/pwman3,

Please note that PR ports/160288 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160288

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-29 18:30:25 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2011-08-31 23:42:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I've been dealing with these anyways
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2011-09-22 19:31:54 UTC
State Changed
From-To: feedback->analyzed

awaiting mentor approval
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-09-23 00:00:34 UTC
eadler      2011-09-22 23:00:25 UTC

  FreeBSD ports repository

  Modified files:
    security/pwman3      Makefile pkg-descr 
  Added files:
    security/pwman3/files patch-pwman-data-drivers_sqlite.py 
                          patch-pwman-exchange_exporter.py 
                          patch-pwman-exchange_importer.py 
  Log:
  - remove dep on databases/py-pysqlite23
  - patch program to not use old pysqlite
  - fix whitespace issue in pkg-descr
  - bump portrevision
  
  PR:             ports/160288
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru>
  Approved by:    maintainer timeout (23 days)
  Approved by:    sahil (mentor)
  
  Revision  Changes    Path
  1.2       +2 -2      ports/security/pwman3/Makefile
  1.1       +11 -0     ports/security/pwman3/files/patch-pwman-data-drivers_sqlite.py (new)
  1.1       +11 -0     ports/security/pwman3/files/patch-pwman-exchange_exporter.py (new)
  1.1       +11 -0     ports/security/pwman3/files/patch-pwman-exchange_importer.py (new)
  1.2       +2 -2      ports/security/pwman3/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Eitan Adler freebsd_committer freebsd_triage 2011-09-23 00:11:35 UTC
State Changed
From-To: analyzed->closed

Committed. Thanks!