By default, pidgin-sipe uses pkg-config to include the first of "nss" (security/nss), "mozilla-nss" (www/libxul) or "microb-engine-nss" (not a FreeBSD port AFAIK) to provide NSS functionality. None of these are listed as dependencies. By default, net-im/libpurple and net-im/pidgin both include a dependency on security/nss (via a config option) and this will be inherited by pidgin-sipe. If this dependency is disabled but either security/nss or www/libxul are installed for other reasons, pidgin-sipe will have an unlisted dependency on that package. Note that if libxul-1.9.2.17_1 is installed without security/nss being installed, pidgin-sipe will fail to build because mozilla-nss is currently broken (see ports/160351). It's possible there are other undocumented implicit dependencies, I only noticed this one due to the mozilla-nss breakage. Fix: The NSS dependency in pidgin-sipe cannot be disabled via a configure knob so pidgin-sipe should probably have a LIB_DEPENDS on security/nss. How-To-Repeat: Build and install net-im/libpurple and net-im/pidgin with NSS disabled. Build and install security/nss Build and install pidgin-sipe pkg_info -r pidgin-sipe-1.11.2_3 | grep nss pkg_info -R nss-\* | grep pidgin show no dependency is recorded. ldd /usr/local/lib/purple-2/libsipe.so | grep nss shows pidgin-sipe depends on files in security/nss
Maintainer of net-im/pidgin-sipe, Please note that PR ports/160352 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160352 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Good find, thanks! I can provide an actual patch if needed. Go ahead and commit it if you have one ready. -john On Wed, Aug 31, 2011 at 10:26 PM, Edwin Groothuis <edwin@freebsd.org> wrote= : > Maintainer of net-im/pidgin-sipe, > > Please note that PR ports/160352 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/160352 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org >
Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it.
pawel 2011-10-18 20:01:09 UTC FreeBSD ports repository Modified files: net-im/pidgin-sipe Makefile Log: Depend on security/nss, fixes misssing dep when net-im/libpurple and net-im/pidgin are build without NSS support - this port still links to it when it's available and this behaviour can be disabled. PR: ports/160352 Reported by: Peter Jeremy <Peter.Jeremy@alcatel-lucent.com> Approved by: maintainer Revision Changes Path 1.31 +3 -2 ports/net-im/pidgin-sipe/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!