Bug 160388 - [PATCH] deskutils/deskbar-applet: conditionally depend on simplejson
Summary: [PATCH] deskutils/deskbar-applet: conditionally depend on simplejson
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 11:10 UTC by R.Mahmatkhanov
Modified: 2011-09-12 19:56 UTC (History)
0 users

See Also:


Attachments
file.diff (1013 bytes, patch)
2011-09-02 11:10 UTC, R.Mahmatkhanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-09-02 11:10:11 UTC
deskbar-applet uncoditionally depends on devel/py-simplejson, but it actually should not. simplejson only used in ${WRKSRC}/deskbar/handlers/googlesearch.py:

"""
try:
    import json
except:
    try:
        import simplejson as json
    except:
        pass
"""

It tries first to import json module (that is a part of python since 2.6) and fallbacks to simplejson if json module is not found.

This patch make it depend on devel/py-simplejson only if python version < 2.6.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-02 11:10:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-09-12 19:40:52 UTC
kwm         2011-09-12 18:40:00 UTC

  FreeBSD ports repository

  Modified files:
    deskutils/deskbar-applet Makefile 
  Log:
  Make py-simplejson a depend if python is below 2.6.
  
  PR:             ports/160388
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru>
  
  Revision  Changes    Path
  1.52      +6 -3      ports/deskutils/deskbar-applet/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Koop Mast freebsd_committer freebsd_triage 2011-09-12 19:56:39 UTC
State Changed
From-To: open->closed

Committed thanks