Right now this port uncoditionally depends on devel/py-simplejson, but it actually should not. They use native json module if running on python 2.6+ and use external simplejson if python < 2.6. In setup.py: """ try: import json except ImportError: install_requires.append('simplejson') """ In other code: """ try: # Specifically import json_loads, to work around some issues with # installations containing incompatible modules named "json". from json import loads as json_loads except ImportError: from simplejson import loads as json_loads """ This patch make it depend on devel/py-simplejson only if python version < 2.6. And for python < 2.6 it's not only build dependency but run dependency too, so change this respectively. tag: simplejson26 Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->flz Over to maintainer (via the GNATS Auto Assign Tool)
Forget to add, also move pkg-plist contents to Makefile to save some inode :) -- Regards, Ruslan Tinderboxing kills... the drives.
rm 2011-11-11 09:34:23 UTC FreeBSD ports repository Modified files: devel/rbtools Makefile Removed files: devel/rbtools pkg-plist Log: - drop dependency on devel/py-simplejson - move contents of pkg-plist into PLIST_FILES - strict python versions to 2.6-2.7 - bump PORTREVISION PR: ports/160395 Submitted by: rm Approved by: flz (maintainer; timeout - 2+ months), miwi (co-mentor) Feature safe: yes Revision Changes Path 1.5 +5 -3 ports/devel/rbtools/Makefile 1.2 +0 -2 ports/devel/rbtools/pkg-plist (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thank you!