Bug 160435 - [PATCH] sysutils/py-supervisor: eliminate py-elementtree dependency
Summary: [PATCH] sysutils/py-supervisor: eliminate py-elementtree dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-03 20:50 UTC by R.Mahmatkhanov
Modified: 2011-09-05 11:00 UTC (History)
0 users

See Also:


Attachments
file.diff (2.01 KB, patch)
2011-09-03 20:50 UTC, R.Mahmatkhanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-09-03 20:50:07 UTC
This port actually don't use py-elementtree, this dep is needed only for www/py-meld3. You can grep for it and will found that the only functional mention of this is in setup.py:

"""
if sys.version_info[:2] < (2, 5):
    # for meld3 (it's a distutils package)
    requires.append('elementtree')
"""

So we can safely remove this two dependencies from this port:
- devel/py-elementtree
- devel/py-celementtree

But this needs to bump USE_PYTHON to 2.5+ (Python 2.4 is EOL anyway).
There is also ports/160304, that updates www/py-meld3 to latest version, that can work with python's elementtree too. 

elementtree is a part of python since 2.5, so this dependency isn't needed after we bump USE_PYTHON to 2.5+. See: http://docs.python.org/library/xml.etree.elementtree.html

While here fix some whitespace bugs in pkg-descr.

tag: dropelementtree

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-03 20:50:14 UTC
Maintainer of sysutils/py-supervisor,

Please note that PR ports/160435 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160435

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-03 20:50:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-09-04 10:08:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 4 hizel 2011-09-05 07:02:31 UTC
I approve. thank you.

-- 
---

e-mail: hizel@vyborg.ru
jabber id: hizel@vyborg.ru
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-09-05 10:54:59 UTC
sunpoet     2011-09-05 09:54:51 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/py-supervisor Makefile pkg-descr 
  Log:
  - Change USE_PYTHON to 2.5+
  - Update *_DEPENDS: remove py-celementtree and py-elementtree
  - Remove trailing space in pkg-descr
  - Bump PORTREVISION for dependency change
  - While I'm here, correct USE_PYTHON range
  
  PR:             ports/160435
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru>
  Approved by:    Ildar Hizbulin <hizel@vyborg.ru>
  
  Revision  Changes    Path
  1.5       +3 -4      ports/sysutils/py-supervisor/Makefile
  1.2       +7 -8      ports/sysutils/py-supervisor/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-09-05 10:55:03 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!