Bug 160441 - [PATCH] dns/curvedns: remove BROKEN on 9.x
Summary: [PATCH] dns/curvedns: remove BROKEN on 9.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dennis Herrmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-03 22:10 UTC by R.Mahmatkhanov
Modified: 2011-09-09 20:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-09-03 22:10:06 UTC
Remove broken on 9.x since it no more true - it builds and install fine on 9.0-BETA1 i386:
"""
===>  Configuring for curvedns-0.88.b_1
===>   configuring may take a couple of minutes
Finished configuring CurveDNS, ready for compiling.
Chosen/picked ABI:		x86
Chosen/picked compiler:		gcc
Chosen/picked compiler options:	-m32 -O3 -fomit-frame-pointer -funroll-loops

We are now ready to compile, run 'make' to do so.
rm@smeshariki3$ sudo make
===>  Building for curvedns-0.88.b_1
"""
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-03 22:10:14 UTC
Maintainer of dns/curvedns,

Please note that PR ports/160441 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160441

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-03 22:10:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dennis Herrmann freebsd_committer freebsd_triage 2011-09-05 12:46:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dhn

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-09-09 19:43:37 UTC
dhn         2011-09-09 18:43:28 UTC

  FreeBSD ports repository

  Modified files:
    dns/curvedns         Makefile 
    dns/curvedns/files   pkg-message.in 
  Log:
  - Fix Build on 9.x
  - Update files/pkg-message.in [1]
  
  PR:             ports/160441
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru>
  Approved by:    maintainer ([1] via mail)
  
  Revision  Changes    Path
  1.5       +4 -4      ports/dns/curvedns/Makefile
  1.3       +15 -5     ports/dns/curvedns/files/pkg-message.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Dennis Herrmann freebsd_committer freebsd_triage 2011-09-09 19:43:40 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 freebsd 2011-09-09 19:54:13 UTC
Hi,

As a previous port-revision made the port conform the BSD convention,
it however unfortunely caused it not to work 'out of the box', so
besides updating the Makefile I like to update the pkg-message.in file:



# diff curvedns.orig curvedns
diff curvedns.orig/Makefile curvedns/Makefile
10c10
< PORTREVISION=		1
---
> PORTREVISION=		2
35,38d34
< .if ${OSVERSION} >= 900000
< BROKEN=		does not configure on 9.X
< .endif
< 
Common subdirectories: curvedns.orig/files and curvedns/files
srv19# diff -ruN curvedns.orig curvedns
diff -ruN curvedns.orig/Makefile curvedns/Makefile
--- curvedns.orig/Makefile	2011-07-19 17:44:30.000000000 +0000
+++ curvedns/Makefile	2011-09-09 18:28:59.000000000 +0000
@@ -7,7 +7,7 @@
 
 PORTNAME=		curvedns
 PORTVERSION=		0.88.b
-PORTREVISION=		1
+PORTREVISION=		2
 CATEGORIES=		dns
 MASTER_SITES=		http://curvedns.on2it.net/releases/
 DISTNAME=		curvedns-0.88-unstable
@@ -32,10 +32,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${OSVERSION} >= 900000
-BROKEN=		does not configure on 9.X
-.endif
-
 .if ${ARCH} == "sparc64"
 BROKEN=		Does not compile on sparc64
 .endif
diff -ruN curvedns.orig/files/pkg-message.in curvedns/files/pkg-message.in
--- curvedns.orig/files/pkg-message.in	2011-07-19 17:44:30.000000000 +0000
+++ curvedns/files/pkg-message.in	2011-09-09 18:37:50.000000000 +0000
@@ -1,22 +1,32 @@
 ###########################################################
 
-     To start using curvedns, finish these tasks:
+  To start using curvedns, finish the following tasks:
 
 ------- generate/install keys -----------------------------
+
  curvedns-keygen %%PREFIX%%/etc/curvedns ns1.example.net
 
 ------- configure -----------------------------------------
- $EDITOR %%PREFIX%%/etc/curvedns/run
- # set user to "bind" (required)
- # adjust IP / ports (if desired)
+
+ $EDITOR %%PREFIX%%/etc/curvedns/run.sample
+ # set user from "curvedns" to "bind" (required!),
+ # adjust IP / port-numbers,
+ # and save as %%PREFIX%%/etc/curvedns/run
+
+ $EDITOR %%PREFIX%%/etc/curvedns/log/run.sample
+ # set user from "curvedns" to "bind" (required!),
+ # and save as %%PREFIX%%/etc/curvedns/log/run
 
 ------- prepare/startup -----------------------------------
+
  mkdir /var/service
  ln -s %%PREFIX%%/etc/curvedns /var/service
  echo svscan_enable=\"YES\" >> /etc/rc.conf
  %%PREFIX%%/etc/rc.d/svscan start
 
 ------- verify --------------------------------------------
+
+ # examples:
  dig @<curvedns-ip> auth-dom.example any
  drill <curvedns-ip> auth-dom.example any