Bug 160510 - [patch] net-p2p/amule-devel: clang build fails (foo vs. this->foo)
Summary: [patch] net-p2p/amule-devel: clang build fails (foo vs. this->foo)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 11:40 UTC by h h
Modified: 2011-09-20 21:40 UTC (History)
0 users

See Also:


Attachments
a.diff (1.03 KB, patch)
2011-09-06 11:40 UTC, h h
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description h h 2011-09-06 11:40:00 UTC

    
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-06 11:40:17 UTC
Maintainer of net-p2p/amule-devel,

Please note that PR ports/160510 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160510

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-06 11:40:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2011-09-12 22:46:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Grab
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2011-09-14 12:30:36 UTC
The patched port builds fine on my 9.0-amd64 laptop with clang and
with 7.4-i386 / 8.2-i386 gcc
tinderboxes, but not with my 9.0-i386 tinderbox without any gcc
installed. The problem seems to
be in the cryptopp port (which builds fine with clang itself) to which
it cannot link properly:

http://rene-ladan.nl:8080/tb/errors/9-FreeBSD-clang/amule-devel-10589.log

Excerpt:
clang++ -W -Wall -Wshadow -Wundef -pthread -D_THREAD_SAFE  -O2 -pipe
-fno-strict-aliasing -pthread -pthread -L/usr/local/lib -o amule
amule-CaptchaDialog.o amule-CaptchaGenerator.o amule-PartFileConvert.o
amule-PartFileConvertDlg.o amule-amule.o amule-BaseClient.o
amule-CanceledFileList.o amule-ClientList.o amule-ClientCreditsList.o
amule-ClientTCPSocket.o amule-ClientUDPSocket.o
amule-CorruptionBlackBox.o amule-DownloadClient.o
amule-DownloadQueue.o amule-ECSpecialCoreTags.o amule-EMSocket.o
amule-EncryptedStreamSocket.o amule-EncryptedDatagramSocket.o
amule-ExternalConn.o amule-FriendList.o amule-IPFilter.o
amule-KnownFileList.o amule-ListenSocket.o amule-MuleUDPSocket.o
amule-SearchFile.o amule-SearchList.o amule-ServerConnect.o
amule-ServerList.o amule-ServerSocket.o amule-ServerUDPSocket.o
amule-SHAHashSet.o amule-SharedFileList.o amule-ThreadTasks.o
amule-UploadBandwidthThrottler.o amule-UploadClient.o
amule-UploadQueue.o amule-Indexed.o amule-Kademlia.o amule-Prefs.o
amule-Search.o amule-UDPFirewallTester.o amule-KademliaUDPListener.o
amule-PacketTracking.o amule-Contact.o amule-RoutingZone.o
amule-amule-gui.o amule-amuleDlg.o amule-AddFriend.o amule-CatDialog.o
amule-ChatSelector.o amule-ChatWnd.o amule-CommentDialog.o
amule-CommentDialogLst.o amule-GenericClientListCtrl.o
amule-ClientDetailDialog.o amule-DirectoryTreeCtrl.o
amule-FileDetailDialog.o amule-KadDlg.o amule-OScopeCtrl.o
amule-PrefsUnifiedDlg.o amule-SearchDlg.o amule-ServerWnd.o
amule-SharedFilesWnd.o amule-StatisticsDlg.o amule-SearchListCtrl.o
amule-DownloadListCtrl.o amule-SourceListCtrl.o
amule-SharedFilePeersListCtrl.o amule-FriendListCtrl.o
amule-ServerListCtrl.o amule-SharedFilesCtrl.o amule-MuleTrayIcon.o
amule-TransferWnd.o amule-amuleAppCommon.o amule-ClientRef.o
amule-DataToText.o amule-ECSpecialMuleTags.o amule-KnownFile.o
amule-GetTickCount.o amule-GuiEvents.o amule-HTTPDownload.o
amule-Logger.o amule-PartFile.o amule-Preferences.o amule-Proxy.o
amule-Server.o amule-Statistics.o amule-StatTree.o amule-UserEvents.o
-L. -lmuleappcommon -Llibs/common -Llibs/ec/cpp -lmulecommon -lec
-lz  -L/usr/local/lib -lcryptopp -L. -lmuleappcore    -L. -lmuleappgui
-L/usr/local/lib -pthread   -L/usr/local/lib   -lwx_gtk2u_adv-2.8
-lwx_gtk2u_core-2.8 -lwx_baseu_net-2.8 -lwx_baseu-2.8
amule-ClientCreditsList.o: In function `CClientCreditsList::CreateKeyPair()=
':
/ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text+0x2379): undefined
reference to `CryptoPP::AlignedDeallocate(void*)'
/ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text+0x2700): undefined
reference to `CryptoPP::AlignedDeallocate(void*)'
amule-ClientCreditsList.o: In function
`CryptoPP::InvertibleRSAFunction::InvertibleRSAFunction()':
/ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text._ZN8CryptoPP21InvertibleRS=
AFunctionC1Ev[_ZN8CryptoPP21InvertibleRSAFunctionC1Ev]+0x133):
undefined reference to `CryptoPP::AlignedDeallocate(void*)'
/ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text._ZN8CryptoPP21InvertibleRS=
AFunctionC1Ev[_ZN8CryptoPP21InvertibleRSAFunctionC1Ev]+0x172):
undefined reference to `CryptoPP::AlignedDeallocate(void*)'
/ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text._ZN8CryptoPP21InvertibleRS=
AFunctionC1Ev[_ZN8CryptoPP21InvertibleRSAFunctionC1Ev]+0x1b3):
undefined reference to `CryptoPP::AlignedDeallocate(void*)'
amule-ClientCreditsList.o:/ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text.=
_ZN8CryptoPP21InvertibleRSAFunctionC1Ev[_ZN8CryptoPP21InvertibleRSAFunction=
C1Ev]+0x1ee):
more undefined references to `CryptoPP::AlignedDeallocate(void*)'
follow
clang++: error: linker command failed with exit code 1 (use -v to see
invocation)
gmake[3]: *** [amule] Error 1

Ren=E9
Comment 5 h h 2011-09-14 17:56:01 UTC
René Ladan <rene@freebsd.org> writes:

> The patched port builds fine on my 9.0-amd64 laptop with clang and
> with 7.4-i386 / 8.2-i386 gcc
> tinderboxes, but not with my 9.0-i386 tinderbox without any gcc
> installed. The problem seems to
> be in the cryptopp port (which builds fine with clang itself) to which
> it cannot link properly:
>
> http://rene-ladan.nl:8080/tb/errors/9-FreeBSD-clang/amule-devel-10589.log
[...]
> OSVERSION=900039
[...]
> amule-ClientCreditsList.o: In function `CClientCreditsList::CreateKeyPair()':
> /ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text+0x2379): undefined reference to `CryptoPP::AlignedDeallocate(void*)'
> amule-ClientCreditsList.o: In function `CryptoPP::InvertibleRSAFunction::InvertibleRSAFunction()':
> /ccache/tmp/ClientCred.tmp.clang.41838.ii:(.text._ZN8CryptoPP21InvertibleRSAFunctionC1Ev[CryptoPP::InvertibleRSAFunction::InvertibleRSAFunction()]+0x133): undefined reference to `CryptoPP::AlignedDeallocate(void*)'

Sorry, 900039 is too old. It does not even guarantee that you're using
latest base-clang r224145 (2011-07-17).

Also, try without ccache like e.9-exp (clang) runs are done.
It should get rid of spurious "argument unused during compilation".
Comment 6 Rene Ladan freebsd_committer freebsd_triage 2011-09-14 18:27:59 UTC
---------- Forwarded message ----------
From: Rene Ladan <rene@freebsd.org>
Date: 2011/9/14
Subject: Re: ports/160510: [patch] net-p2p/amule-devel: clang build
fails (foo vs. this->foo)
To: h h <aakuusta@gmail.com>

I have the latest version (clang r135360 2011-07-17) installed in the
Tinderbox. 900039 is still up-to-date regarding the toolchain, the other
changes are related to Capsicum and bumping shared libraries.

I think either cryptopp or amule-devel is doing something wrong here.

> Also, try without ccache like e.9-exp (clang) runs are done.
> It should get rid of spurious "argument unused during compilation".
>
That's not harmful in itself :-)

Rene
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-09-20 21:30:19 UTC
rene        2011-09-20 20:30:04 UTC

  FreeBSD ports repository

  Added files:
    net-p2p/amule-devel/files patch-src-ObservableQueue.h 
  Log:
  Fix build with clang.
  
  PR:             ports/160510
  Submitted by:   "h h" [aakuusta gmail.com]
  Approved by:    maintainer timeout (swell.k, 14 days)
  
  Revision  Changes    Path
  1.1       +20 -0     ports/net-p2p/amule-devel/files/patch-src-ObservableQueue.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Rene Ladan freebsd_committer freebsd_triage 2011-09-20 21:30:56 UTC
State Changed
From-To: feedback->closed

Committed, thanks