Dovecot2 and dovecot2-pigeonhole upgrade to 2.0.15 and 0.2.4. I'm submitting the two in one patch because it's best to commit them together. Fix: Patch attached with submission follows:
Hi, The reason for the patch in dovecot2-pigeonhole/files/patch-doc_Makefile_in hasn't suddenly gone away with v0.2.4. Without a regenerated version of this patch to apply to v0.2.4, there will be left-over files : === Checking filesystem state list of extra files and directories in / (not present before this port was installed but present after it was deinstalled) 3357455 3 drwxr-xr-x 2 root wheel 4 Sep 19 08:08 usr/local/share/doc/dovecot/sieve 3357456 10 -r--r--r-- 1 root wheel 4173 Sep 19 08:08 usr/local/share/doc/dovecot/sieve/vacation.txt 3357457 11 -r--r--r-- 1 root wheel 5016 Sep 19 08:08 usr/local/share/doc/dovecot/sieve/spamtest-virustest.txt Please refer to ports/158173 for an explanation of why this doc patch is necessary. Can you also please keep in mind, just because a patch no longer applies cleanly, this doesn't mean that the patch (or more specifically, the issue that it addresses) is no longer relevant. I strongly recommend that you test future PR patches with either a tinderbox or ports-mgmt/porttools e.g., so that you can identify issues such as this (left-over files) and have the opportunity to fix them before submitting a PR. I've attached a regenerated dovecot2-pigeonhole/files/patch-doc_Makefile_in so that the port won't have any left-over files. Regards, Jase. -- [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158173#reply4
Hi, OK, thanks. On 09/19/11 10:34, Jase Thew wrote: > Hi, > > The reason for the patch in > dovecot2-pigeonhole/files/patch-doc_Makefile_in hasn't suddenly gone > away with v0.2.4. Without a regenerated version of this patch to apply > to v0.2.4, there will be left-over files : > > === Checking filesystem state > list of extra files and directories in / (not present before this port > was installed but present after it was deinstalled) > 3357455 3 drwxr-xr-x 2 root wheel 4 Sep 19 > 08:08 usr/local/share/doc/dovecot/sieve > 3357456 10 -r--r--r-- 1 root wheel 4173 Sep 19 > 08:08 usr/local/share/doc/dovecot/sieve/vacation.txt > 3357457 11 -r--r--r-- 1 root wheel 5016 Sep 19 > 08:08 usr/local/share/doc/dovecot/sieve/spamtest-virustest.txt > > Please refer to ports/158173 for an explanation of why this doc patch > is necessary. > > Can you also please keep in mind, just because a patch no longer > applies cleanly, this doesn't mean that the patch (or more > specifically, the issue that it addresses) is no longer relevant. > > I strongly recommend that you test future PR patches with either a > tinderbox or ports-mgmt/porttools e.g., so that you can identify > issues such as this (left-over files) and have the opportunity to fix > them before submitting a PR. > > I've attached a regenerated > dovecot2-pigeonhole/files/patch-doc_Makefile_in so that the port won't > have any left-over files. > > Regards, > > Jase. > > -- > > [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158173#reply4
Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it.
pawel 2011-10-25 20:29:48 UTC FreeBSD ports repository Modified files: mail/dovecot2 Makefile distinfo mail/dovecot2-pigeonhole Makefile distinfo mail/dovecot2-pigeonhole/files patch-doc_Makefile_in Log: - Update mail/dovecot2 to 2.0.15 - Update mail/dovecot2-pigeonhole to 0.2.4 PR: ports/160820 Submitted by: Attila Nagy <bra@fsn.hu> (maintainer) -> update Jase Thew <freebsd@beardz.net> -> updated patch-doc_Makefile_in Revision Changes Path 1.9 +2 -2 ports/mail/dovecot2-pigeonhole/Makefile 1.4 +2 -2 ports/mail/dovecot2-pigeonhole/distinfo 1.2 +6 -6 ports/mail/dovecot2-pigeonhole/files/patch-doc_Makefile_in 1.9 +1 -1 ports/mail/dovecot2/Makefile 1.7 +2 -2 ports/mail/dovecot2/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!