multimedia/mjpegtools installs bin/qttoy4m and bin/y4mtoqt when built with WITH_QUICKTIME defined. They are never included in pkg-plist. The attached patch adds them to pkg-plist only when the option is checked. Should PORTREVISION be increased when files were previously left behind? Should it be increased in the case of an update that removes entries from a pkg-plist that point to a file that is not included? Is it ever okay to set PORTREVISION in the .if test (maybe with a comment by the main one at the start of the file) so only those impacted by the change will spend time on the rebuild? I did not follow the PLIST_SUB convention used elsewhere in the file of ":=" and instead used the plain "=" that I have seen with other ports and in the porter's handbook. A change of := looks like it needs the : listed in pkg-plist variables too if it is changed to that. Fix: Patch attached with submission follows: How-To-Repeat: install multimedia/mjpegtools with QUICKTIME checked at config screen; packaging and uninstalls will leave behind two files.
Responsible Changed From-To: freebsd-ports-bugs->freebsd-multimedia Over to maintainer (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-multimedia->swills I'll take it.
State Changed From-To: open->closed Committed. Thanks!
swills 2012-03-03 02:52:48 UTC FreeBSD ports repository Modified files: multimedia/mjpegtools Makefile pkg-plist Log: - Fix plist issue with QUICKTIME=true PR: ports/161871 Submitted by: "Edward.Sanford.Sutton, III" <mirror176@cox.net> Revision Changes Path 1.80 +2 -0 ports/multimedia/mjpegtools/Makefile 1.23 +2 -0 ports/multimedia/mjpegtools/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"