Bug 161911 - [patch] editors/emacs-devel: broken pthread_sigmask()
Summary: [patch] editors/emacs-devel: broken pthread_sigmask()
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-23 00:40 UTC by Nali Toja
Modified: 2011-10-30 16:50 UTC (History)
0 users

See Also:


Attachments
pthread_sigmask.diff (739 bytes, patch)
2011-10-23 00:40 UTC, Nali Toja
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nali Toja 2011-10-23 00:40:05 UTC
The last gnulib merge in r105666 breaks the one defined in libthr by
marking it with defines checked against the stub in libc.

  PTHREAD_SIGMASK_INEFFECTIVE [1]
  PTHREAD_SIGMASK_UNBLOCK_BUG [2]

while HAVE_PTHREAD assumes the symbol comes from -lpthread. It's a bit
unclear whether this is a bug in gnulib, emacs or actually a feature[3],
so let's follow gnulib instructions (at least for now)

    dnl The module 'threadlib' is not in use, due to --avoid=threadlib being
    dnl specified.
    dnl The package either has prepared CPPFLAGS and LIBS for use of POSIX:2008
    dnl threads, or wants to build single-threaded programs.
    if test $ac_cv_func_pthread_sigmask = yes; then
      dnl pthread_sigmask exists and does not require extra libraries.
      dnl Assume that it is declared.
      :
    
as according to GNULIB_TOOL_FLAGS in WRKSRC/Makefile.in emacs uses
--avoid=threadlib and some system libs (e.g. dbus) bring -lpthread, anyway.

[1] http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=2616a65
[2] http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=2909043
[3] nox11 emacs seems to work fine without linking against -lpthread

How-To-Repeat: $ emacs -Q -nw /path/to/bsd.port.mk (or any other versioned file)
M-x vc-annotate

  (Annotate [waiting...] from bsd.port.mk)

In my case it permanently waits while consuming 100% cpu in top(1) where
`cvs' process (from `list-processes') has long since exited.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-23 00:40:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Nali Toja 2011-10-24 04:34:54 UTC
obsolete since r106173, fixed in upstream as bug#9852

[1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9852
Comment 3 Ashish SHUKLA freebsd_committer freebsd_triage 2011-10-24 09:38:11 UTC
Hi,

Thanks for reporting. I'll update editors/emacs-devel in a week after I return
back to my place.

Thanks
-- 
Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
freebsd.org!ashish | http://people.freebsd.org/~ashish/

Avoid Success At All Costs !!
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-10-30 15:08:27 UTC
ashish      2011-10-30 15:08:13 UTC

  FreeBSD ports repository

  Modified files:
    editors/emacs-devel  Makefile distinfo 
    editors/emacs-devel/files patch-configure.in 
  Added files:
    editors/emacs-devel/files patch-src_sysdep.c 
  Removed files:
    editors/emacs-devel/files patch-src_s_freebsd.h 
  Log:
  - Update to bzr revision 106240
  - Remove patches which are now in upstream[1]
  - Add patch to implement process support for FreeBSD from Emacs bug# 5243[1]
  
  PR:             ports/161911[1]
  Submitted by:   Nali Toja <nalitoja@gmail.com>[1]
  
  Revision  Changes    Path
  1.59      +1 -1      ports/editors/emacs-devel/Makefile
  1.32      +2 -2      ports/editors/emacs-devel/distinfo
  1.10      +1 -10     ports/editors/emacs-devel/files/patch-configure.in
  1.2       +0 -25     ports/editors/emacs-devel/files/patch-src_s_freebsd.h (dead)
  1.1       +237 -0    ports/editors/emacs-devel/files/patch-src_sysdep.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2011-10-30 16:09:41 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-10-30 16:46:20 UTC
ashish      2011-10-30 16:46:10 UTC

  FreeBSD ports repository

  Modified files:
    editors/emacs-devel  Makefile 
  Added files:
    editors/emacs-devel/files patch-src_s_freebsd.h 
  Log:
  - Bring back patch in ports/161181 which got accidentally,
    removed in previous commit
  - Bump PORTREVISION
  
  PR:             ports/161911
  
  Revision  Changes    Path
  1.60      +1 -0      ports/editors/emacs-devel/Makefile
  1.3       +23 -0     ports/editors/emacs-devel/files/patch-src_s_freebsd.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"