Bug 161925 - databases/p5-Dancer-Plugin-Redis: Fixed reconnect function
Summary: databases/p5-Dancer-Plugin-Redis: Fixed reconnect function
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-perl (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-23 10:40 UTC by Grzegorz Blach
Modified: 2011-11-01 01:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.04 KB, patch)
2011-10-23 10:40 UTC, Grzegorz Blach
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Blach 2011-10-23 10:40:09 UTC
In databases/p5-Redis method ping() has changed behavior,
now in disconnect state, it return false instead of throwing exception.
http://api.metacpan.org/source/MELO/Redis-1.904/Changes

This cause p5-Dancer-Plugin-Redis to crash on reconnect.
And p5-Dancer-Plugin-Redis wasn't updated upstream yet,
so I attached a lite patch for fix this crash.

Fix: Apply attached patch

Patch attached with submission follows:
How-To-Repeat: 1. Build simple Dancer app with Redis plugin.
2. Run it and open page which do some database operations.
3. Wait 10 minutes for autodisconnect from db.
4. Try refresh page -> You get uncatched exception in Dancer app
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-23 10:40:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-11-01 01:36:49 UTC
clsung      2011-11-01 01:36:41 UTC

  FreeBSD ports repository

  Modified files:
    databases/p5-Dancer-Plugin-Redis Makefile 
  Log:
  - Fixed reconnect function
  - In databases/p5-Redis method ping() has changed behavior,
    now in disconnect state, it return false instead of throwing exception.
    http://api.metacpan.org/source/MELO/Redis-1.904/Changes
  
    This cause p5-Dancer-Plugin-Redis to crash on reconnect.
    And p5-Dancer-Plugin-Redis wasn't updated upstream yet,
    so I attached a lite patch for fix this crash.
  - bump PORTREVISION
  
  PR:             ports/161925
  Submitted by:   maintainer (Grzegorz Blach)
  
  Revision  Changes    Path
  1.2       +8 -2      ports/databases/p5-Dancer-Plugin-Redis/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Cheng-Lung Sung freebsd_committer freebsd_triage 2011-11-01 01:37:01 UTC
State Changed
From-To: open->closed

Committed. Thank You.